From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67062C433ED for ; Thu, 8 Apr 2021 12:49:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAA8261105 for ; Thu, 8 Apr 2021 12:49:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAA8261105 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IL/K8OBSJHgRCUPZFc5eOcAnw1R3t/fNNou5B0oM3/U=; b=QIctpwtDz+FLNFsMjUtBgal9n LOithwWrlTY/NAk2sJKRqRnE59TO2vai8k5zWV/SdusAFV9RiCZskMVrCbYKKKmWx7so6bz6uXvmk C6OLNUA0He9zPFQN0CbeB1/KbIkNPuEfRPSQ/NDRvHuNzTboLIExxXXQjqbvb1kN6xwoJ1XgkI1/j Ne0KRV3LunK5qi1/l9NOu13coWD3VCBU0gTM+ccZS5L9FCWZ4EYfifFc82eKHOhhZakAdAz9C3Bcj Qka9u1aovCMwSiAogItG+tOS87xEHhNiuaq97suaSwGhuLceqmtcJS80rld+XxAm4gCfg2nDPVQcn cxM0fGG5w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUU5L-0082Us-6Y; Thu, 08 Apr 2021 12:48:35 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUU57-0082TA-Vi; Thu, 08 Apr 2021 12:48:23 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id A213E22234; Thu, 8 Apr 2021 14:48:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1617886097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yyglUwoXCuz0ysTDi3YJvq4eALpeWh9ZYLQqhbUo0lE=; b=eGMCh33PKQSr1IcC4SXPqEI87EmqQVMRbunXLG1RTcr9lRiR5UaXoGdiZKuegxfHu/1OCt JcX6cLF9kglN4YtT4ev96AzJ9Xdo6IpwuVpf5bCWaGk9jVYqLYi43qbI+LFUlpTWhUlITL HhV0t0QsGEoNoOGaWgBWjBZpm4FTYVU= MIME-Version: 1.0 Date: Thu, 08 Apr 2021 14:48:16 +0200 From: Michael Walle To: Pratyush Yadav Cc: Nishanth Menon , Tero Kristo , Rob Herring , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mark Brown , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, Lokesh Vutla Subject: Re: [RFC PATCH 2/6] mtd: spi-nor: core: consolidate read op creation In-Reply-To: <20210311191216.7363-3-p.yadav@ti.com> References: <20210311191216.7363-1-p.yadav@ti.com> <20210311191216.7363-3-p.yadav@ti.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <22d1042e061e355b0ddd122ef1228535@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_134822_252140_D7A1F90F X-CRM114-Status: UNSURE ( 8.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Am 2021-03-11 20:12, schrieb Pratyush Yadav: > Currently the spi_mem_op to read from the flash is used in two places: > spi_nor_create_read_dirmap() and spi_nor_spimem_read_data(). In a later > commit this number will increase to three. Instead of repeating the > same > code thrice, add a function that returns a template of the read op. The > callers can then fill in the details like address, data length, data > buffer location. > > Signed-off-by: Pratyush Yadav Reviewed-by: Michael Walle ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/