public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Li Nan <linan122@huawei.com>,
	linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Zhihao Cheng <chengzhihao1@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Hou Tao <houtao1@huawei.com>,
	Yang Erkun <yangerkun@huawei.com>, Yu Kuai <yukuai3@huawei.com>,
	Zhang Yi <yi.zhang@huawei.com>
Subject: Re: [PATCH v2] ubi: block: fix memleak in ubiblock_create()
Date: Sun, 14 Apr 2024 11:16:34 +0200	[thread overview]
Message-ID: <22f324ce-552a-4f6a-b4e5-2d84a00010aa@web.de> (raw)
In-Reply-To: <20231208074629.1656356-1-linan666@huaweicloud.com>

Can it be nicer to use the term “memory leak” instead of “memleak”
in the patch subject?


…
> 'gd' will not be put anymore. Fix it by putting 'gd' directly.

Would the following wording variant be more desirable?

   … anymore.
   Thus pass the variable “gd” to a put_disk() call directly.


Would you like to add the tag “Fixes” accordingly?

Regards,
Markus

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2024-04-14  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  7:46 [PATCH v2] ubi: block: fix memleak in ubiblock_create() linan666
2023-12-30  6:33 ` Li Nan
2024-01-29 13:27 ` Li Nan
2024-04-14  9:16 ` Markus Elfring [this message]
2024-04-15  1:31   ` Li Nan
2024-04-15  6:33 ` Dan Carpenter
2024-04-18  9:07   ` Li Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22f324ce-552a-4f6a-b4e5-2d84a00010aa@web.de \
    --to=markus.elfring@web.de \
    --cc=chengzhihao1@huawei.com \
    --cc=houtao1@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linan122@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox