From: David Woodhouse <dwmw2@infradead.org>
To: Clive Davies <cdavies@altera.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Fwd: jffs2 & new linux zlib
Date: Wed, 06 Mar 2002 09:29:36 +0000 [thread overview]
Message-ID: <23140.1015406976@redhat.com> (raw)
In-Reply-To: <200203060847.g268lKv09419@localhost.localdomain>
cdavies@altera.com said:
> What, no comments at all? Shall I just check this in then? - it works
> for me.
Sorry, I missed this one, possibly due to it mentioning 2.5, or the
combination of https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=53659
and iso8859-15 mails. Neither of which are your fault.
The code against which your patch was made never existed in my CVS tree. It
was fundamentally broken, as you observed. Whoever did the zlib changes in
2.5 evidently didn't verify that _either_ jffs2 or ppp_deflate were still
working. Both are now fixed in Linus' tree, and I've also back-ported the
(fixed) shared zlib code to 2.4, so that I can import the changes into CVS
without breaking the 2.4 build. Now, we allocate the workspaces once at
init time, rather than doing it each time we need to compress/decompress
something.
2.4 zlib backport patch at ftp.kernel.org:/pub/linux/kernel/people/dwmw2
or in BK tree at http://linux-mtd.bkbits.net:8080/zlib-2.4 (note jffs2-2.4
tree sitting beside it).
That tree differs from the jffs2-2_4-branch only in the zlib changes, which
will make their way onto the jffs2-2_4-branch when the zlib changes get
into 2.4.x.
> I'm not sure that this is the best approach., maybe it would be better
> to try and reduce the size of the deflate_workspace & inflate
> workspace in zlib? (This might be a ridiculous idea, I haven't a clue
> how zlib works) Any suggestions?
The inflate workspace is OK - that's only about 40KiB. If we could reduce
the deflate workspace from its current 400-odd, that would be useful.
--
dwmw2
prev parent reply other threads:[~2002-03-06 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-06 8:47 Fwd: jffs2 & new linux zlib Clive Davies
2002-03-06 9:29 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23140.1015406976@redhat.com \
--to=dwmw2@infradead.org \
--cc=cdavies@altera.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox