From: David Woodhouse <dwmw2@infradead.org>
To: mpc@mail2000.com.tw
Cc: "" <linux-mtd@lists.infradead.org>
Subject: Re: Patch to support TQM8xxL board
Date: Tue, 12 Jun 2001 09:12:38 +0100 [thread overview]
Message-ID: <2490.992333558@redhat.com> (raw)
In-Reply-To: <992279958.89789.mpc@mail2000.com.tw>
Looks good generally - thanks. A few requests though...
mpc@mail2000.com.tw said:
> +dep_tristate ' CFI Flash device mapped on TQM8xxL' CONFIG_MTD_TQM8xxL $CONFIG_MTD_CFI $CONFIG_TQM8xxL
It's normal to have config options in all capitals. I'd rather not break
that convention. Also, we require a Configure.help entry for this option.
> + * Do not forget also choose CFI_LITTLE_ENDIAN......
Actually HOST_ENDIAN should also work, shouldn't it?
> +#ifndef CONFIG_MTD_TQM8xxL
> +#error This is for TQM8xxL platform only
> +#endif
Please omit this. It shouldn't be necessary.
> +#ifdef CONFIG_TQM8xxL
The Config.in entry prevents us from compiling this file otherwise, so this
should also be superfluous.
--
dwmw2
next prev parent reply other threads:[~2001-06-12 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-11 17:19 Patch to support TQM8xxL board Kirk Lee
2001-06-12 8:12 ` David Woodhouse [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-06-12 17:00 Kirk Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2490.992333558@redhat.com \
--to=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mpc@mail2000.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox