Patch to support TQM8xxL board

Patch to support TQM8xxL board

[Kirk Lee]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi:

 I just finished adding TQM8xxL(www.denx.de)support
 into MTD package.
 This patch is against mtd-shapshot-20010610.
 I do not know if anyone is interested in this.
 Patch attached...

 Have a nice day!

 kirk

----== Mailed via Openfind ==-----
http://mail2000.com.tw/ 提供免費電子郵件信箱


[-- Attachment #2: patch-mtd-snapshot-20010610.gz --]
[-- Type: application/octet-stream, Size: 3153 bytes --]

Re: Patch to support TQM8xxL board

[David Woodhouse]

Looks good generally - thanks. A few requests though...

mpc@mail2000.com.tw said:
> +dep_tristate '  CFI Flash device mapped on TQM8xxL' CONFIG_MTD_TQM8xxL $CONFIG_MTD_CFI $CONFIG_TQM8xxL 

It's normal to have config options in all capitals. I'd rather not break 
that convention. Also, we require a Configure.help entry for this option.

> + * Do not forget also choose CFI_LITTLE_ENDIAN......

Actually HOST_ENDIAN should also work, shouldn't it?

> +#ifndef CONFIG_MTD_TQM8xxL
> +#error This is for TQM8xxL platform only
> +#endif

Please omit this. It shouldn't be necessary.

> +#ifdef CONFIG_TQM8xxL 

The Config.in entry prevents us from compiling this file otherwise, so this 
should also be superfluous.

--
dwmw2

Re: Patch to support TQM8xxL board

[Kirk Lee]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

>> +dep_tristate '  CFI Flash device mapped on >>TQM8xxL' CONFIG_MTD_TQM8xxL $CONFIG_MTD_CFI >>$CONFIG_TQM8xxL
>It's normal to have config options in all >capitals. Also, we require a Configure.help entry >for this option.

 Fixed and also add related entry into Configure.help.

>>CFI_LITTLE_ENDIAN......
>Actually HOST_ENDIAN should also work, shouldn't it?

 I just take a rough try.
 HOST_ENDIAN does not work.
 TQM8xxL is a Embedded PowerPC based board, MPC8xx
 series, and ppc-linux for that series use 'lwbrx' 
 and 'stwbrx' instruction to implement 'readl'
 and 'writel'.
 This may be the reason, I guess.....

>> +#ifndef CONFIG_MTD_TQM8xxL
>> +#error This is for TQM8xxL platform only
>> +#endif
>Please omit this. It shouldn't be necessary.

 Fixed.

 Thanks

 kirk


----== Mailed via Openfind ==-----
http://mail2000.com.tw/ 提供免費電子郵件信箱


[-- Attachment #2: patch-mtd-snapshot20010610.gz --]
[-- Type: application/octet-stream, Size: 3454 bytes --]