From: David Woodhouse <dwmw2@infradead.org>
To: Peter Kundrat <kundrat@pkx.sk>
Cc: mtd@infradead.org
Subject: Re: small nftl fix
Date: Wed, 18 Oct 2000 17:45:55 +0100 [thread overview]
Message-ID: <26998.971887555@redhat.com> (raw)
In-Reply-To: <20001004042629.A2152@napri.sk>
kundrat@pkx.sk said:
> When writing to an empty fs on nftl, I always got garbled partition
> table. Looking at the nftl.c, there seems to be a problem with
> overwriting media header (which seems to be at the FirstPhysicalEUN).
>
Sorry for the delayed response. Your patch looks good. However, I believe
the spec allows the header units to be in places other than the first two
physical units of the NFTL, so it would be better to make sure we don't use
(EUN == nftl->MediaUnit || EUN == nftl->SpareMediaUnit) rather than
hardcoding that to not use (EUN < nftl->MediaHdr.FirstPhysicalEUN + 2)
In practice, I don't really expect that to happen, but we might as well be
pedantic in our adherence to the NFTL spec.
In the meantime, could anyone else who's seen NFTL corruption please try
Peter's patch?
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
next prev parent reply other threads:[~2000-10-18 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E13dhnU-0007fK-00@infradead.org>
2000-09-27 6:05 ` journalled fs on partitioned flash Peter Kundrat
2000-09-27 9:17 ` David Woodhouse
2000-09-27 11:22 ` David Given
2000-09-27 11:29 ` David Woodhouse
2000-10-04 2:26 ` small nftl fix Peter Kundrat
2000-10-18 16:45 ` David Woodhouse [this message]
2000-09-27 22:35 ` journalled fs on partitioned flash Peter Kundrat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26998.971887555@redhat.com \
--to=dwmw2@infradead.org \
--cc=kundrat@pkx.sk \
--cc=mtd@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox