From: Michal Simek <michal.simek@amd.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
Date: Tue, 4 Feb 2025 09:41:47 +0100 [thread overview]
Message-ID: <29724b4a-dc1d-416e-b8d5-11e85cdf7a85@amd.com> (raw)
In-Reply-To: <20250203213042.12657-1-robh@kernel.org>
On 2/3/25 22:30, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../devicetree/bindings/mtd/arasan,nand-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> index 15b63bbb82a2..b90d3b48c2f2 100644
> --- a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> @@ -42,7 +42,7 @@ required:
> - clock-names
> - interrupts
>
> -unevaluatedProperties: true
> +unevaluatedProperties: false
>
> examples:
> - |
Good thing to do. And we should extend binding to cover other properties which
are missing in description.
Pretty much remove arasan,has-mdma from DTs and describe power-domains and
num-cs in binding.
Acked-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-02-04 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 21:30 [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined Rob Herring (Arm)
2025-02-04 8:41 ` Michal Simek [this message]
2025-02-04 19:39 ` Conor Dooley
2025-02-07 14:47 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29724b4a-dc1d-416e-b8d5-11e85cdf7a85@amd.com \
--to=michal.simek@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox