From: Michael Walle <michael@walle.cc>
To: Tudor.Ambarus@microchip.com
Cc: pratyush@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
vigneshr@ti.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, Takahiro.Kuwano@infineon.com
Subject: Re: [PATCH v2 6/7] mtd: spi-nor: add generic flash driver
Date: Mon, 07 Nov 2022 19:22:51 +0100 [thread overview]
Message-ID: <2b56d38b76660692117103c9de213cdc@walle.cc> (raw)
In-Reply-To: <848f22da-7f1b-ae93-99d3-65a5f31cb122@microchip.com>
Am 2022-11-01 09:46, schrieb Tudor.Ambarus@microchip.com:
> On 8/11/22 01:06, Michael Walle wrote:
>> --- a/drivers/mtd/spi-nor/core.c
>> +++ b/drivers/mtd/spi-nor/core.c
>> @@ -1632,6 +1632,16 @@ static const struct spi_nor_manufacturer
>> *manufacturers[] = {
>> &spi_nor_xmc,
>> };
>>
>> +static const struct flash_info spi_nor_generic_flash = {
>> + .name = "spi-nor-generic",
>
> How about "jedec,spi-nor" instead? The series looks good, I intend to
> test it
> and apply it soon.
I had that string before actually but decided against it because it
looks like "jedec" is the vendor, which is (a) not true for any flash
and (b) if it would be a vendor, it should go into the manufacturer
property, which isn't supported at the moment.
That being said, I don't care too much. After all, it's just a name.
(and yes, I'm on vacation till next week ;)
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-11-07 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 22:06 [PATCH v2 0/7] mtd: spi-nor: generic flash driver Michael Walle
2022-08-10 22:06 ` [PATCH v2 1/7] mtd: spi-nor: hide jedec_id sysfs attribute if not present Michael Walle
2022-08-10 22:06 ` [PATCH v2 2/7] mtd: spi-nor: sysfs: hide manufacturer if it is not set Michael Walle
2022-08-10 22:06 ` [PATCH v2 3/7] mtd: spi-nor: remember full JEDEC flash ID Michael Walle
2022-08-10 22:06 ` [PATCH v2 4/7] mtd: spi-nor: move function declaration out of sfdp.h Michael Walle
2022-08-10 22:06 ` [PATCH v2 5/7] mtd: spi-nor: fix select_uniform_erase to skip 0 erase size Michael Walle
2022-08-10 22:06 ` [PATCH v2 6/7] mtd: spi-nor: add generic flash driver Michael Walle
2022-11-01 8:46 ` Tudor.Ambarus
2022-11-07 14:42 ` Tudor.Ambarus
2022-11-07 18:22 ` Michael Walle [this message]
2022-11-21 13:35 ` Tudor.Ambarus
2022-08-10 22:06 ` [PATCH v2 7/7] mtd: spi-nor: sysfs: print JEDEC ID for " Michael Walle
2022-11-21 13:41 ` [PATCH v2 0/7] mtd: spi-nor: " Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b56d38b76660692117103c9de213cdc@walle.cc \
--to=michael@walle.cc \
--cc=Takahiro.Kuwano@infineon.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox