From: Pratyush Yadav <pratyush@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Takahiro Kuwano <takahiro.kuwano@infineon.com>,
linux-mtd@lists.infradead.org
Subject: Re: Sashiko to track linux-mtd
Date: Wed, 24 Jun 2026 10:57:37 +0200 [thread overview]
Message-ID: <2vxz4iismi2m.fsf@kernel.org> (raw)
In-Reply-To: <875x38mlk7.fsf@bootlin.com> (Miquel Raynal's message of "Wed, 24 Jun 2026 09:42:16 +0200")
On Wed, Jun 24 2026, Miquel Raynal wrote:
> Hello MTD folks,
>
> I mentioned it rapidly on IRC but I believe a formal e-mail is more
> appropriate. I consider asking the Sashiko team to track linux-mtd to
> help us with reviews:
>
> * sashiko@lists.linux.dev
> * Roman Gushchin <roman.gushchin@linux.dev>
>
> I believe Sashiko will be a useful tool given that our time is
> limited. We were already monitoring the output of Sashiko when other
> (Sashiko enabled) mailing lists were copied, so I propose to officially
> add linux-mtd to the list.
I have been using Sashiko a lot and I think it is quite useful. It helps
catch bugs that are very hard for humans to see.
It doesn't do so well at design and high level patch review, so we
aren't out of a job just yet ;-)
>
> Richard said he was fine with the idea as long as it remained a tool. I
> agree with this approach, Sashiko is not the Alpha & Omega, but I
> believe it proved itself useful just by the amount of corner cases it
> managed to catch already. Not all recommendations should be followed and
> we are not looking for an empty Sashiko response for merging.
>
> There is apparently the possibility to tune the prompt per subsystem. At
> this stage I haven't thought very deeply about it and considered not
> adding any subsystem specific rules. Maybe the SPI NOR team wants to
> come up with some guidelines, such as the need for a record (using the
> script in the documentation) for new chips additions. I would propose to
> not delay the addition of our mailing list for that. This does not need
> to be done from day 1, as we can make PRs to their GH repository with
> these extra requirements whenever we are ready, see below.
I think we should not do subsystem prompts unless we see it keeps
tripping up on something it can't infer from looking at the source code.
That is normally things like "this is a problem but we don't support
this".
Other than that, you want it to run free and look at the source code as
the source of truth, and not the prompts, which can go out of date.
Also, I think the prompts were more useful for older models which
weren't as capable. Today's models are very good at looking at code, and
generally don't need that much hand holding.
>
> Link: https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2026-06-24 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 7:42 Sashiko to track linux-mtd Miquel Raynal
2026-06-24 8:57 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxz4iismi2m.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=richard@nod.at \
--cc=takahiro.kuwano@infineon.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox