From: Pratyush Yadav <pratyush@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
<linux-mtd@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2] mtd: spi-nor: Rename spi_nor_spimem_check_op()
Date: Tue, 17 Mar 2026 10:46:49 +0000 [thread overview]
Message-ID: <2vxzjyvad97q.fsf@kernel.org> (raw)
In-Reply-To: <20260317102115.321807-1-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Tue, 17 Mar 2026 11:21:15 +0100")
On Tue, Mar 17 2026, Miquel Raynal wrote:
> This helper really is just a little helper for internal purposes, and is
> I/O operation oriented, despite its name. It has already been misused
> in commit 5008c3ec3f89 ("mtd: spi-nor: core: Check read CR support"), so
> rename it to clarify its purpose: it is only useful for reads and page
> programs.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
This one is tricky. It won't compile without "mtd: spi-nor: Fix RDCR
controller capability core check". So to take it through spi-nor/next, I
would need to rebase the branch on the -rc in which the RDCR patch [0]
lands.
And while I don't think it is necessary, the history will be a bit
cleaner if mtd/next is also based on that -rc. No strong preferences
about that though.
Does this sound good to you or is there a better way of handling this?
[0] https://lore.kernel.org/linux-mtd/20260317101842.319656-1-miquel.raynal@bootlin.com/T/#u
[...]
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-03-17 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 10:21 [PATCH v2] mtd: spi-nor: Rename spi_nor_spimem_check_op() Miquel Raynal
2026-03-17 10:46 ` Pratyush Yadav [this message]
2026-03-17 13:21 ` Miquel Raynal
2026-03-17 16:13 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzjyvad97q.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox