public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: UBIFS does not mount after powerfail
Date: Sun, 19 Nov 2017 21:52:44 +0100	[thread overview]
Message-ID: <3046677.dsXx11Gx8o@blindfold> (raw)
In-Reply-To: <c0730b1f-861b-6c3d-b3aa-77825a5d4470@colorfullife.com>

Manfred,

Am Donnerstag, 16. November 2017, 17:51:26 CET schrieb Manfred Spraul:
> Hi Richard,
> 
> (2nd mail, forced as non-html)
> 
> On 11/15/2017 09:29 PM, Richard Weinberger wrote:
> > Manfred,
> > 
> > Am Mittwoch, 15. November 2017, 21:04:14 CET schrieb Manfred Spraul:
> >> Hi,
> >> 
> >> On 11/14/2017 07:49 PM, Manfred Spraul wrote:
> >>> Hi Richard,
> >>> 
> >>> On 11/13/2017 10:06 PM, Richard Weinberger wrote:
> >>>> No, the image that contains the first logical error.
> >>>> UBIFS can mount even if there are many problems with the structure.
> >>>> Therefore I need you to enable chk_fs.
> >>> 
> >>> Done - and I even found a 2nd instance where the image got bad:
> >>> https://sourceforge.net/projects/calculix-rpm/files/ubifs/chk_fs/
> >> 
> >> Sorry for the self-reply, I did another test:
> >> I applied "ubifs: replay: Detect and kill orphaned xattrs", i.e.
> >> https://patchwork.ozlabs.org/patch/780667/.
> > 
> > I would be astonished if that patch would fix your issues, it is supposed
> > to fix a -ENOSPC problem.
> 
> After enabling chk_fs, the result was
> 
> > UBIFS error (ubi0:0 pid 5104): dbg_check_filesystem: inode 39012 nlink is
> > 1, but calculated nlink is 0
> and link count 1 instead of 0 sounded a bit like a leak.
> 
> dmesg:
> https://sourceforge.net/projects/calculix-rpm/files/ubifs/chk_fs/result-1680
> 78.txt/download image:
> https://sourceforge.net/projects/calculix-rpm/files/ubifs/chk_fs/image-16807
> 8.bin/download
> 
> Thus I decided that it might make sense to try a patch that should
> improve the behavior with leaks.
> And it did not take much time.

Hmmm, maybe we confuse UBIFS that much that it fails differently in your case.

Anyway, let's reconsider.
If you're facing the problem which should be solved by the said patch, we can 
do a check.

1. Do you face the issue without ecryptfs?
2. Does it also happen without xattrs being used at all? Hence also without 
ecryptfs?
 
I'm afraid that the patch has still problems (it is not merged for reasons).
So, please keep on a stock kernel for now.

Thanks,
//richard

  reply	other threads:[~2017-11-19 20:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-12 19:26 UBIFS does not mount after powerfail Manfred Spraul
2017-11-12 19:54 ` Richard Weinberger
2017-11-13 20:59   ` Manfred Spraul
2017-11-13 21:06     ` Richard Weinberger
2017-11-14 18:49       ` Manfred Spraul
2017-11-15 20:04         ` Manfred Spraul
2017-11-15 20:29           ` Richard Weinberger
2017-11-16 16:51             ` Manfred Spraul
2017-11-19 20:52               ` Richard Weinberger [this message]
2017-11-23 22:03                 ` Manfred Spraul
2017-11-28 21:00                   ` Richard Weinberger
2017-11-30 17:41                     ` Manfred Spraul
2017-11-30 20:03                       ` Richard Weinberger
2017-12-01  7:41                         ` Manfred Spraul
2017-12-01 10:01                           ` Richard Weinberger
2017-12-01 17:38                             ` Manfred Spraul
2017-12-05 13:27                           ` Richard Weinberger
2017-12-05 19:11                             ` Manfred Spraul
2017-12-05 20:06                               ` Richard Weinberger
2017-12-05 22:19                                 ` Richard Weinberger
2017-12-06 18:42                                   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3046677.dsXx11Gx8o@blindfold \
    --to=richard@nod.at \
    --cc=linux-mtd@lists.infradead.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox