From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lithops.sigma-star.at ([195.201.40.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSh75-0000Dj-Gd for linux-mtd@lists.infradead.org; Tue, 12 Jun 2018 11:05:25 +0000 From: Richard Weinberger To: Boris Brezillon Cc: Masahiro Yamada , linux-mtd , Mark Rutland , Rob Herring , Brian Norris , DTML , Linux Kernel Mailing List , Rob Herring , Miquel Raynal , Philipp Rosenberger , David Woodhouse , Marek Vasut Subject: Re: [PATCH 2/2] mtd: rawnand: denali: add more clocks Date: Tue, 12 Jun 2018 13:05:03 +0200 Message-ID: <3063058.uoHcm7uEyX@blindfold> In-Reply-To: <20180612130329.1c17311f@bbrezillon> References: <1528799515-1356-1-git-send-email-yamada.masahiro@socionext.com> <20180612130329.1c17311f@bbrezillon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am Dienstag, 12. Juni 2018, 13:03:29 CEST schrieb Boris Brezillon: > On Tue, 12 Jun 2018 19:36:06 +0900 > Masahiro Yamada wrote: > > > Maybe, the commit title should be: > > > > mtd: rawnand: denali: add more clocks and improve setup_data_interface > > Or you split that in 2 commits, one retrieving the new clks, and the > other one fixing/improving ->setup_data_interface(). Yeah, please split the patch. It needs to go into -stable as well. One patch should just unbreak the driver. Thanks, //richard