From: David Woodhouse <dwmw2@infradead.org>
To: joakim.tjernlund@lumentis.se
Cc: "Dave Ellis" <DGE@sixnetio.com>, linux-mtd@lists.infradead.org
Subject: Re: Disk blocks for long periods
Date: Tue, 06 Aug 2002 13:14:47 +0100 [thread overview]
Message-ID: <30768.1028636087@redhat.com> (raw)
In-Reply-To: <IGEFJKJNHJDCBKALBJLLAEIBFFAA.joakim.tjernlund@lumentis.se>
joakim.tjernlund@lumentis.se said:
> BTW, is it neccesary to use spin_lock_bh()? Can we not get away with
> just spin_lock()? I am not very good at locking, but I think xxx_bh is
> only needed when interrupts can can execute the locked code and
> currently there are no interrupts in this code path(I think).
> Is it not true that xxx_bh() also disables interrupts? If so, there
> must be rather long periods with interrupts turned off in
> cfi_cmdset_xxxx.c?
spin_lock_bh() should not disable interrupts, only bottom-halves. It was
used to protect against timers, because we intend(ed) to have the erase
completion done from a timer. At the moment there's no real need to use
anything but spin_lock().
--
dwmw2
next prev parent reply other threads:[~2002-08-06 12:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-05 18:50 Disk blocks for long periods Dave Ellis
2002-08-06 10:06 ` Joakim Tjernlund
2002-08-06 12:14 ` David Woodhouse [this message]
2002-08-06 13:52 ` Jörn Engel
2002-08-06 13:53 ` David Woodhouse
2002-08-06 16:45 ` Joakim Tjernlund
2002-08-07 9:51 ` David Woodhouse
2002-08-08 7:23 ` Joakim Tjernlund
2002-08-08 8:02 ` David Woodhouse
2002-08-08 8:32 ` Joakim Tjernlund
2002-08-08 8:40 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2002-08-07 16:42 Dave Ellis
2002-08-08 7:08 ` Joakim Tjernlund
2002-08-08 8:08 ` David Woodhouse
2002-08-08 9:15 ` Joakim Tjernlund
2002-08-08 9:18 ` David Woodhouse
2002-08-06 20:16 Dave Ellis
2002-08-06 21:06 ` Joakim Tjernlund
2002-08-06 14:53 Dave Ellis
2002-08-06 15:09 ` Joakim Tjernlund
2002-08-07 11:11 ` David Woodhouse
2002-08-05 10:35 MTD Partition problems David Woodhouse
2002-08-05 13:35 ` Disk blocks for long periods Joakim Tjernlund
2002-08-05 13:44 ` David Woodhouse
2002-08-05 13:59 ` Joakim Tjernlund
2002-08-05 14:12 ` David Woodhouse
2002-08-05 14:32 ` Joakim Tjernlund
2002-08-05 14:42 ` David Woodhouse
2002-08-05 21:45 ` Jasmine Strong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30768.1028636087@redhat.com \
--to=dwmw2@infradead.org \
--cc=DGE@sixnetio.com \
--cc=joakim.tjernlund@lumentis.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox