From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dell-paw-3.cambridge.redhat.com ([195.224.55.237] helo=passion.cambridge.redhat.com) by pentafluge.infradead.org with esmtp (Exim 3.22 #1 (Red Hat Linux)) id 17cNTo-0000mI-00 for ; Wed, 07 Aug 2002 10:51:48 +0100 From: David Woodhouse In-Reply-To: References: To: joakim.tjernlund@lumentis.se Cc: "Dave Ellis" , linux-mtd@lists.infradead.org Subject: Re: Disk blocks for long periods Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 07 Aug 2002 10:51:44 +0100 Message-ID: <31147.1028713904@redhat.com> Sender: linux-mtd-admin@lists.infradead.org Errors-To: linux-mtd-admin@lists.infradead.org List-Help: List-Post: List-Subscribe: , List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: joakim.tjernlund@lumentis.se said: > Can the JFFS2 layer also use spin_lock() instead of spin_lock_bh()? > Shold we try not to disable bottom-halves or does it not matter? Well, the MTD API documentation (in my head) says that the erase completion callback may be called in bottom-half context (i.e. from a timer), which is why JFFS2 uses spin_lock_bh(). I suppose we could change that. -- dwmw2