From: David Woodhouse <dwmw2@infradead.org>
Cc: mtd@infradead.org, ollie@sis.com.tw, linuxbios@lanl.gov
Subject: Re: DiskOnChip 2000/Millennium driver merge.
Date: Fri, 01 Dec 2000 17:45:56 +0000 [thread overview]
Message-ID: <31230.975692756@redhat.com> (raw)
In-Reply-To: <8574.975681632@redhat.com>
dwmw2@infradead.org said:
> If anyone else with Millennium hardware could take a look at the
> differences between doc2000.c and doc2001.c, especially Ollie who
> actually knows what he's doing, that'd be very much appreciated.
I think it's fixed. It now works on the DiskOnChip2000 - the culprit was
the change to make doc_write_ecc() actually write the ECC data rather than
just putting it into a buffer for the caller to subsequently write out.
Just continuing to write bytes to the IO register got it working on the
Millennium. Not on the 2000, though. I had to change it to store the data
and call doc_write_oob() at the end of doc_write_ecc() in order to make it
work on the 2000.
I expect that to continue to work on the Millennium, but unfortunately I
seem to have blown mine up - docprobe can't even see it any more :(
The combined 2000/Millennium driver now ought to be completely working.
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
next prev parent reply other threads:[~2000-12-01 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-01 14:40 DiskOnChip 2000/Millennium driver merge David Woodhouse
2000-12-01 17:45 ` David Woodhouse [this message]
2000-12-01 17:50 ` David Woodhouse
2000-12-02 1:40 ` Ollie Lho
2000-12-02 11:10 ` David Woodhouse
2000-12-04 2:08 ` Ollie Lho
-- strict thread matches above, loose matches on Subject: below --
2000-12-03 9:45 Vadim Khamlinsky
2000-12-04 16:44 Miguel Freitas
2000-12-04 15:53 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31230.975692756@redhat.com \
--to=dwmw2@infradead.org \
--cc=linuxbios@lanl.gov \
--cc=mtd@infradead.org \
--cc=ollie@sis.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox