From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799EBC2D0A3 for ; Wed, 4 Nov 2020 05:43:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE33221556 for ; Wed, 4 Nov 2020 05:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WaxoZIJO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="A+1jORDT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE33221556 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zUPgbsT5mCxEfnofOnhP6S1Pkbe8kfhPSQIYcFwof/Y=; b=WaxoZIJOsZgAxD2tJleXhLSBM /Q8sy39nGpGk6+5uVjt+TiEENxDRK+xXs7f5zbSGUocYbhLgmfyO06spBzuev1H6nrBRh8TeiZYku VpKhEueh2cW0s1WQS6b1xtlEEAQwCCxbPIszaonwngW9XuPvGTYYpFo2J13ZmBvkrnLSDMzc19yfe kCRzBezhhrePw//WZDDkfu1CbhXSC5AyMAZUEi+FzeUWWqCIElWTa3gy7buluIRXK2LBBqQMqgrFl g1OX8I6v/xJizcebpBwJ4msnSLhdlD/WsfmyTEzKXK2YegRMikfkrGSmnTJ/30B+SDV/WdOE3N7r1 6Due6nsDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaBYs-0008JM-Km; Wed, 04 Nov 2020 05:42:22 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaBYn-0008IH-5V for linux-mtd@lists.infradead.org; Wed, 04 Nov 2020 05:42:20 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A45gCdq082908; Tue, 3 Nov 2020 23:42:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604468532; bh=ZMjFopd0KFk9SYTJqQxgo4gVMZEmtDRUKhJ2peyg/qM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=A+1jORDTV7CNDlzG5SivsreGYMBBeN4SG1UnuV6ZxTmR8yazdt1NZ6DbLy8/j6GZ+ 1b2QcmwN/I8K6JS5eVY5suGKM4e9kO2bJUqWfehUtg+To1U6UrQfQxh5Z+WLqtgN7K Ik35AF8jcnuQGvcOsHr5MXFBSJ23qB/fsqjejT1Y= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A45gCrs090057 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Nov 2020 23:42:12 -0600 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 3 Nov 2020 23:42:12 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 3 Nov 2020 23:42:11 -0600 Received: from [10.250.233.179] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A45g9x6085297; Tue, 3 Nov 2020 23:42:10 -0600 Subject: Re: [PATCH] mtd: cfi_cmdset_0002: Use status register where possible To: Joakim Tjernlund , "miquel.raynal@bootlin.com" References: <20201022154506.17639-1-joakim.tjernlund@infinera.com> <20201030184736.4ec434f5@xps13> <20201030195251.687809f7@xps13> <931f422255204f0420e6f1b79657f9770ce0cf6e.camel@infinera.com> From: Vignesh Raghavendra Message-ID: <31ce9a84-d949-c1d1-a8c6-44ead119ca1b@ti.com> Date: Wed, 4 Nov 2020 11:12:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <931f422255204f0420e6f1b79657f9770ce0cf6e.camel@infinera.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_004220_000738_197FEC71 X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-mtd@lists.infradead.org" , "stable@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Joakim On 10/31/20 4:56 PM, Joakim Tjernlund wrote: > On Fri, 2020-10-30 at 19:52 +0100, Miquel Raynal wrote: >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. >> >> >> Hi Joakim, >> >> Joakim Tjernlund wrote on Fri, 30 Oct >> 2020 18:39:35 +0000: >> >>> On Fri, 2020-10-30 at 18:47 +0100, Miquel Raynal wrote: >>>> >>>> Hi Joakim, >>> >>> Hi Miquel >>> >>>> >>>> Please Cc the MTD maintainers, not only the list (get_maintainers.pl). >>> >>> I figure all maintainers are on the list ? >> >> I personally don't look at the list very often. I expect patches to be >> directed to me (in the current case, Vignesh) when I am concerned. > > Added Vignesh > As Miquel suggested, I look at patches on mailing list at a lower priority than patches that are CC'd to me. >> >>> >>>> >>>> Joakim Tjernlund wrote on Thu, 22 Oct >>>> 2020 17:45:06 +0200: >>>> >>>>> Commit "mtd: cfi_cmdset_0002: Add support for polling status register" >>>>> added support for polling the status rather than using DQ polling. >>>>> However, status register is used only when DQ polling is missing. >>>>> Lets use status register when available as it is superior to DQ polling. >>>>> >>>> >>>> I will let vignesh comment about the content (looks fine by me) but you will >>>> need a Fixes tag here. >>> >>> This is not a Fixes situation, no bug just a hw enabling thing. >>> Also, I would like to see the Status patches be backported to 4.19 as well. >> >> Backporting features is IMHO not relevant. I guess stable kernel only >> take fixes... > > This is not a feature really and the 5.4 stable did get them, I ask 4.19 get them too. > commit 4844ef80305d ("mtd: cfi_cmdset_0002: Add support for polling status register") was added in 5.3 and therefore is part of 5.4. But note that this is a "new feature" and therefore won't be backported to kernels older than 5.3. Similarly, this patch (when accepted) is not a candidate for stable kernel backports because the intention of enabling polling status register for Write Completion is to enable flashes that "don't" support DQ polling at all (mainly HyperFlash). Enabling this for all flashes that support the feature is not a bug fix IMO. Also, there isn't enough testing to prove that feature works for all CFI NOR flashes on all platforms and therefore would be risky to be backported to stable kernels. Regards Vignehs ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/