Re: [PATCH] XATTR support in JFFS2

Jörn Engel
2005-08-24T16:34:58Z

On Wed, 24 August 2005 19:08:38 +0800, Ma Yun wrote:
>
> Thank joern! I am sorry for my poor kernel code experience.

Your code is rather good for someone of poor experience.

> I have modified the patch.
>
> Below is the implemention mechanism :)

Thank you. After thinking about this some more, I agree with dwmw2
that Kaigai-san's design makes more sense for most users. Your
design is fine for your special case, but lacking for other potential
users.

Kaigai-san said that he wanted to pick up some of the suggestions and
implement a new patch soon, which will likely be the basis of what we
will merge. So, if you could afford the time and work with him on a
merge candidate patch, that would be great!

The most important issue to think about would be sharing of attributes
between different files/directories. It appears to be a frequent
usage pattern that many files have identical attributes, which would
waste quite a bit of space otherwise.

Jörn

--
Fancy algorithms are buggier than simple ones, and they're much harder
to implement. Use simple algorithms as well as simple data structures.
-- Rob Pike