From: Richard Weinberger <richard@nod.at>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
boris.brezillon@free-electrons.com, marek.vasut@gmail.com,
cyrille.pitchen@wedev4u.fr, dedekind1@gmail.com,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 0/2] mtd: use put_device() if device_register fail
Date: Mon, 12 Mar 2018 15:32:29 +0100 [thread overview]
Message-ID: <3321429.TYNOhWIX1S@blindfold> (raw)
In-Reply-To: <4a280604-16f2-776b-d997-d5882af6fe35@gmail.com>
Arvind,
Am Montag, 12. März 2018, 06:51:24 CET schrieb Arvind Yadav:
> On Monday 12 March 2018 01:05 AM, Richard Weinberger wrote:
> > Am Freitag, 9. März 2018, 11:50:47 CET schrieb Arvind Yadav:
> >> if device_register() returned an error! Always use put_device()
> >> to give up the reference initialized.
> >>
> >> Arvind Yadav (2):
> >> [PATCH 1/2] mtd: use put_device() if device_register fail
> >> [PATCH 2/2] mtd: ubi: use put_device() if device_register fail
> >
> > Uhh, this is not obvious. Does device_register() really always return with
> > a reference held in all (error) cases?
> >
> > Thanks,
> > //richard
>
> if device_register() returned an error! Always use put_device()
> to give up the reference initialized.(-- Please see the comment
> for device_register() ). put_device() is able to handle those case
> where it'll not return a reference.
You are right.
For both patches:
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
prev parent reply other threads:[~2018-03-12 14:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 10:50 [PATCH 0/2] mtd: use put_device() if device_register fail Arvind Yadav
2018-03-09 10:50 ` [PATCH 1/2] " Arvind Yadav
2018-03-14 14:36 ` Boris Brezillon
2018-03-17 9:45 ` arvindY
2018-03-19 10:43 ` Martin Habets
[not found] ` <5AAFF9C6.2010800@gmail.com>
2018-03-21 10:08 ` Martin Habets
2018-03-09 10:50 ` [PATCH 2/2] mtd: ubi: " Arvind Yadav
2018-03-14 18:56 ` Boris Brezillon
2018-03-14 19:25 ` Richard Weinberger
2018-03-15 6:41 ` Arvind Yadav
2018-03-11 19:35 ` [PATCH 0/2] mtd: " Richard Weinberger
2018-03-12 5:51 ` Arvind Yadav
2018-03-12 14:32 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3321429.TYNOhWIX1S@blindfold \
--to=richard@nod.at \
--cc=arvind.yadav.cs@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).