public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Kyungmin Park <kyungmin.park@samsung.com>
To: Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: OneNAND: Check first or second pages for bad block information
Date: Mon, 22 Jan 2007 07:33:16 +0000 (GMT)	[thread overview]
Message-ID: <3686708.94231169451196140.JavaMail.weblogic@ep_ml23> (raw)

Hi,

I'm not sure we have to check 2nd page. Yes, Spec. says we will check 1st and 2nd ones.

It increase the boot time even though it's smaller one than others.

Let me think, when we check 2nd page case.
In initial bad, no need to check 2nd page.
In runtime bad, it is only happend when first page write failed. But during write it has non-0xFF value. so next time it will be detected as invalid.

How do you think about it?

Thank you,
Kyungmin Park


------- Original Message -------
Sender : Adrian Hunter<ext-adrian.hunter@nokia.com> 
Date   : Jan 19, 2007 23:37
Title  : [PATCH] [MTD] OneNAND: Check first or second pages for bad block
 information


OneNAND records bad block information in the out-of-band area of
either the first or second page of a block.  Due to a logic error,
only the first page was being checked.

Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
---
 drivers/mtd/onenand/onenand_bbt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_bbt.c b/drivers/mtd/onenand/onenand_bbt.c
index 90db8f5..aa46b7f 100644
--- a/drivers/mtd/onenand/onenand_bbt.c
+++ b/drivers/mtd/onenand/onenand_bbt.c
@@ -68,7 +68,7 @@ static int create_bbt(struct mtd_info *m
 
 	printk(KERN_INFO "Scanning device for bad blocks\n");
 
-	len = 1;
+	len = 2;
 
 	/* We need only read few bytes from the OOB area */
 	scanlen = ooblen = 0;
-- 
1.4.3




             reply	other threads:[~2007-01-22  7:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-22  7:33 Kyungmin Park [this message]
2007-01-22  8:45 ` OneNAND: Check first or second pages for bad block information Adrian Hunter
2007-01-22  9:13 ` Artem Bityutskiy
  -- strict thread matches above, loose matches on Subject: below --
2007-01-22 11:59 Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3686708.94231169451196140.JavaMail.weblogic@ep_ml23 \
    --to=kyungmin.park@samsung.com \
    --cc=ext-adrian.hunter@nokia.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox