From: Michael Walle <michael@walle.cc>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Vlim <vlim@gigadevice.com>,
pratyush@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
vigneshr@ti.com, akumarma@amd.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, vikhyat.goyal@amd.com
Subject: Re: [PATCH V1 1/1] linux: drivers: mtd: spi-nor: gigadevice.c
Date: Fri, 21 Jul 2023 09:41:36 +0200 [thread overview]
Message-ID: <3795b6594981a236481f70f9172d140b@walle.cc> (raw)
In-Reply-To: <130b3742-fe0b-2030-654f-0cf8863c1479@linaro.org>
>>
>> { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256)
>> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>
> The locking support is not part of the JEDEC SFDP standard, but vendors
> can define their own SFDP tables where they describe the locking
> support. So for now, if you want to enable locking you have to specify
> the locking flags, whatever they are. There are different flavors of
> block protection locking, with 3 or 4 block protection bits, their
> order, etc. You'll have to check the datasheet.
I've seen that gigadevice has their own proprietary SFDP table which
also indicates locking. I'd prefer to have a parser for these, esp.
because the patch is coming from the vendor itself :)
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-07-21 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 4:28 [PATCH V1 1/1] linux: drivers: mtd: spi-nor: gigadevice.c Victor Lim
2023-07-20 6:25 ` kernel test robot
2023-07-20 6:53 ` Tudor Ambarus
2023-07-20 7:05 ` Michael Walle
[not found] ` <TY0PR06MB56580D3FEE55389F41E33398BB3EA@TY0PR06MB5658.apcprd06.prod.outlook.com>
2023-07-21 6:06 ` Tudor Ambarus
[not found] ` <TY0PR06MB56581B9A28DCD7A7270CFC0ABB3FA@TY0PR06MB5658.apcprd06.prod.outlook.com>
2023-07-21 7:38 ` Tudor Ambarus
2023-07-21 7:41 ` Michael Walle [this message]
2023-07-21 7:42 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3795b6594981a236481f70f9172d140b@walle.cc \
--to=michael@walle.cc \
--cc=akumarma@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
--cc=vikhyat.goyal@amd.com \
--cc=vlim@gigadevice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).