From: Aaron Sierra <asierra@xes-inc.com>
To: Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2 v2] nand_base: SOFT_BCH: Request strength over bytes
Date: Thu, 29 Jan 2015 10:46:08 -0600 (CST) [thread overview]
Message-ID: <391096737.68264.1422549968500.JavaMail.zimbra@xes-inc.com> (raw)
In-Reply-To: <1048272995.147101.1421278891164.JavaMail.zimbra@xes-inc.com>
----- Original Message -----
> From: "Aaron Sierra" <asierra@xes-inc.com>
> Sent: Wednesday, January 14, 2015 5:41:31 PM
>
> Previously, we requested that drivers pass ecc.size and ecc.bytes when
> using NAND_ECC_SOFT_BCH. However, a driver is likely to only know the ECC
> strength required for its NAND, so each driver would need to perform a
> strength-to-bytes calculation.
>
> Avoid duplicating this calculation in each driver by asking drivers to
> pass ecc.size and ecc.strength so that the strength-to-bytes calculation
> need only be implemented once.
>
> This reverts/generalizes this commit:
> mtd: nand: Base BCH ECC bytes on required strength
>
> Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> v2:
> * nandsim: Set ECC strength to chip->ecc.strength
> * nand_base: Don't provide ECC bytes-to-strength backward compat
>
> drivers/mtd/nand/nand_base.c | 14 ++++++++------
> drivers/mtd/nand/nandsim.c | 1 +
> drivers/mtd/nand/sunxi_nand.c | 2 --
> 3 files changed, 9 insertions(+), 8 deletions(-)
>
Is this patch still being considered despite the changes requested for
the 2nd patch in this series?
-Aaron
next prev parent reply other threads:[~2015-01-29 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2021171878.109755.1421108768347.JavaMail.zimbra@xes-inc.com>
2015-01-13 0:35 ` [PATCH 1/2] nand_base: SOFT_BCH: Request strength over bytes Aaron Sierra
2015-01-14 9:34 ` Boris Brezillon
2015-01-14 19:08 ` Aaron Sierra
2015-01-14 23:41 ` [PATCH 1/2 v2] " Aaron Sierra
2015-01-29 16:46 ` Aaron Sierra [this message]
2015-02-02 5:12 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=391096737.68264.1422549968500.JavaMail.zimbra@xes-inc.com \
--to=asierra@xes-inc.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox