Re: MTD CVS update: 'mtd/fs/jffs inode-v22.c Makefile inode.c'

Sébastien Côté
2000-06-16T14:49:15Z

Alexander Larsson wrote:

> I did the most obvious conversions, but i had to leave a couple of things
> because that need more thinking and testing:
>
> jffs_read_super() - Does it really has to lock the superblock here?

Ext2 does it in 2.2 and it seemed right to me. If the fs changes while
it is being built, this is really not a good thing.

> jffs_read_page() - I've done some changes here in the 2.3 version that
> might be intresting to 2.2. These are mainly page handling stuff, you need
> to check that carefully.

I'll have to check what changes you're talking about but IIRC the page
handling changed quite a bit between 2.2 and 2.3.

> jffs_file_write() - The 2.3 version has some file-size handling (SIGXFSZ)
> that could be interesting for 2.2. There is also some semaphore locking
> that 2.2 doesn't have which I'm a bit unsure of if it is needed in 2.2.
> The *pos handling can maybe also be moved over.
>
> There are also some comments (/* Is this really needed in 2.2?
> */) sprinkled in the code. These are mainly corner-cases which I and al
> viro has removed from the 2.3 code because they are handled by the VFS.
> Probably most of these are handled by the 2.2 VFS too...
>
> Also there are some french comments in the code that i left there, because
> i don't understand them.

Sorry about that. I completly forgot them when I sent my tree to David
:)

--
Sébastien Côté