public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Vrabel <dvrabel@arcom.co.uk>
To: mtd@infradead.org
Subject: cfi_cmdset_0001.c: do_write_buffer: wrong length
Date: Fri, 08 Dec 2000 14:45:18 +0000	[thread overview]
Message-ID: <3A30F3FE.5C9781CD@arcom.co.uk> (raw)

Hi,

In cfi_cmdset_0001.c do_write_buffer writes an incorrect length to the
chip

    cfi_write(map, CMD((len/(cfi->device_type*CFIDEV_INTERLEAVE))-1),
cmd_adr);

which with 1 x16 chip in x8 mode eg on the SBC-MediaGX (buswidth == 1;
interleave == 1; 
devicetype == 2) works out as

    cfi_write(map, CMD(len/2-1), cmd_adr); <-- Fails

When it should be

    cfi_write(map, CMD(len-1), cmd_adr); <-- Works

Should it it be?
    cfi_write(map, CMD(len/map->buswidth-1), cmd_adr);

David Vrabel



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

             reply	other threads:[~2000-12-08 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-12-08 14:45 David Vrabel [this message]
2000-12-08 18:21 ` cfi_cmdset_0001.c: do_write_buffer: wrong length Nicolas Pitre
2000-12-08 19:56   ` D. Vrabel
2000-12-18 22:13     ` Shane Nay
2000-12-18 22:24     ` Shane Nay
2000-12-19  9:41       ` David Vrabel
2000-12-18 23:07         ` Shane Nay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A30F3FE.5C9781CD@arcom.co.uk \
    --to=dvrabel@arcom.co.uk \
    --cc=mtd@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox