* module names in request_module()
@ 2001-07-13 1:36 Tim Hockin
2001-07-13 6:52 ` David Woodhouse
0 siblings, 1 reply; 5+ messages in thread
From: Tim Hockin @ 2001-07-13 1:36 UTC (permalink / raw)
To: linux-mtd
Hi all, I've noticed a problem:
if I depmod a module that needs cfi and cfi_probe is not loaded,
request_module fails, because it is looking for the module named "cfi" not
"cfi_probe".
should we fix this?
--
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: module names in request_module()
2001-07-13 1:36 module names in request_module() Tim Hockin
@ 2001-07-13 6:52 ` David Woodhouse
2001-07-13 18:15 ` Tim Hockin
0 siblings, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2001-07-13 6:52 UTC (permalink / raw)
To: Tim Hockin; +Cc: linux-mtd
thockin@sun.com said:
> if I depmod a module that needs cfi and cfi_probe is not loaded,
> request_module fails, because it is looking for the module named "cfi"
> not "cfi_probe".
Does v1.9 of chipreg.c fix it correctly?
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: module names in request_module()
2001-07-13 6:52 ` David Woodhouse
@ 2001-07-13 18:15 ` Tim Hockin
2001-07-13 18:17 ` David Woodhouse
0 siblings, 1 reply; 5+ messages in thread
From: Tim Hockin @ 2001-07-13 18:15 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd
David Woodhouse wrote:
>
> thockin@sun.com said:
> > if I depmod a module that needs cfi and cfi_probe is not loaded,
> > request_module fails, because it is looking for the module named "cfi"
> > not "cfi_probe".
>
> Does v1.9 of chipreg.c fix it correctly?
only for cfi
the problem is that the module name is not predictable from the "probe"
name.
cfi -> cfi_probe.o
jedec -> jedec.o
ram -> map_ram.o
rom -> map_rom.o
amd_flash -> amd_flash.o
there is no way to have that knowledge a priori with modules.
So we have three options:
1) rename files to match their probe names
2) rename probe names to match module names
3) use modules.conf to give external fixes for internal flaws
I'm leaning towards #2. Comments?
--
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: module names in request_module()
2001-07-13 18:15 ` Tim Hockin
@ 2001-07-13 18:17 ` David Woodhouse
2001-07-14 1:07 ` Tim Hockin
0 siblings, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2001-07-13 18:17 UTC (permalink / raw)
To: Tim Hockin; +Cc: linux-mtd
thockin@sun.com said:
> So we have three options:
> 1) rename files to match their probe names
> 2) rename probe names to match module names
> 3) use modules.conf to give external fixes for internal flaws
> I'm leaning towards #2. Comments?
Fine.
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: module names in request_module()
2001-07-13 18:17 ` David Woodhouse
@ 2001-07-14 1:07 ` Tim Hockin
0 siblings, 0 replies; 5+ messages in thread
From: Tim Hockin @ 2001-07-14 1:07 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd
David Woodhouse wrote:
>
> thockin@sun.com said:
> > So we have three options:
> > 1) rename files to match their probe names
> > 2) rename probe names to match module names
> > 3) use modules.conf to give external fixes for internal flaws
> > I'm leaning towards #2. Comments?
>
> Fine.
in CVS now. Will this be propogated to 2.4.7 or should I send it to Linus
also?
--
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2001-07-14 0:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-07-13 1:36 module names in request_module() Tim Hockin
2001-07-13 6:52 ` David Woodhouse
2001-07-13 18:15 ` Tim Hockin
2001-07-13 18:17 ` David Woodhouse
2001-07-14 1:07 ` Tim Hockin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox