From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wall.comdev.cc ([63.150.62.162] helo=rangers.comdev.cc) by pentafluge.infradead.org with esmtp (Exim 3.22 #1 (Red Hat Linux)) id 16HST7-0000KV-00 for ; Fri, 21 Dec 2001 16:24:21 +0000 Message-ID: <3C2363B5.6CA0740C@comdev.cc> Date: Fri, 21 Dec 2001 08:30:45 -0800 From: Adam Wozniak MIME-Version: 1.0 To: David Woodhouse CC: linux-mtd@lists.infradead.org Subject: Re: patch for 64 bit wide flash References: <3C1FD0DD.9A4F2CC8@comdev.cc> <3698.1008926053@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-mtd-admin@lists.infradead.org Errors-To: linux-mtd-admin@lists.infradead.org List-Help: List-Post: List-Subscribe: , List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: David Woodhouse wrote: > adam.wozniak@comdev.cc said: > > I've got a 64 bit wide flash consisting of eight 8bit wide chips. > > Here's a patch against the 2.4.16 kernel > > I'm a little concerned about the following bit - gcc is fairly crap at > dealing with 64-bit datatypes. I'd prefer to do that only if it's > necessary. Can we define a cfi_busword type which is only as big as we need > - so it's only a __u64 if CONFIG_MTD_CFI_B8 is set? > > @@ -337,9 +393,9 @@ > */ > static inline __u32 cfi_send_gen_cmd(u_char cmd, __u32 cmd_addr, __u32 base, > struct map_info *map, struct cfi_private *cfi, > - int type, __u32 *prev_val) > + int type, __u64 *prev_val) > { > - __u32 val; > + __u64 val; > __u32 addr = base + cfi_build_cmd_addr(cmd_addr, CFIDEV_INTERLEAVE, type); > > val = cfi_build_cmd(cmd, map, cfi); That's fine with me. I'll release a patch later today or tomorrow. =) --Adam -- Adam Wozniak (KG6GZR) COM DEV Wireless - Digital and Software Systems awozniak@comdev.cc 3450 Broad St. 107, San Luis Obispo, CA 93401 http://www.comdev.cc Voice: (805) 544-1089 Fax: (805) 544-2055