From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MF5SO-0004Fk-NB for linux-mtd@lists.infradead.org; Fri, 12 Jun 2009 12:02:11 +0000 Received: from epmmp2 (mailout4.samsung.com [203.254.224.34]) by mailout1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0KL400703K3DYH@mailout1.samsung.com> for linux-mtd@lists.infradead.org; Fri, 12 Jun 2009 21:02:01 +0900 (KST) Received: from amulsaha ([107.108.214.27]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0KL400421K3BAD@mmp2.samsung.com> for linux-mtd@lists.infradead.org; Fri, 12 Jun 2009 21:02:01 +0900 (KST) Date: Fri, 12 Jun 2009 17:27:00 +0530 From: Amul Saha Subject: Re: [patch 01/14] mtd: Flex-OneNAND support To: dedekind@infradead.org Message-id: <3E83C7DF574149B78FFE8D12094FAF6D@sisodomain.com> Content-transfer-encoding: 7BIT References: <5205AB2678D945D194F6372BE9297942@sisodomain.com> <1243432517.11172.32.camel@localhost.localdomain> <1244554687.4538.16.camel@macbook.infradead.org> <9061742E1E7840C6B7016A210EF848AB@sisodomain.com> <1244712906.5847.414.camel@localhost.localdomain> <2AF67696C6634054B7CFDF7A9C19865D@sisodomain.com> <1244803363.5847.446.camel@localhost.localdomain> Cc: vishak.g@samsung.com, apgmoorthy , kyungmin.park@samsung.com, linux-mtd@lists.infradead.org, akpm@linux-foundation.org, David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Artem, >> +#ifdef MODULE >> + flexonenand_setup(flex_bdry_info); >> +#endif > > Why do you need this ifdef? What is the fundamental difference between > onenand.ko as a module and onenand compiled-in? > flexonenand_setup( ) need not be called, when OneNAND is built-in. This function-call will cause overhead unwantedly on every boot, during OneNAND scan. flexonenand_setup( ) call is needed only when it has been built as a module. Regards, Amul Kumar Saha