From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B27C48BE8 for ; Mon, 24 Jun 2019 09:34:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F06442089F for ; Mon, 24 Jun 2019 09:34:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PcC9zOPH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QHvgV1VB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F06442089F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ofcLpvzwWFSIgyLNQDdUgnSVIjWvpD9wxsqXSU9Szno=; b=PcC9zOPH9czeqY H2JG996oQcUhJe5bh6wWt3BfLry8sJHXIgYl02TfbLzKiKPhPuoBxtCqOxi8BkA6Ai8OAwL53Wmxr VScvQvLmYpMrkrTzr5B5xtZfOuiT63B2tfhsyZr8sCrQwA+Pcvd0fJZfSj6tuWmLLhQfGx0t0p1Iy 1JZ1oaaTycUkLPZ+1EvJd2/mU+9LfsxGT7SI4M2zzJtDadGUs5ybJ+KCWNiiQK9SYXOvB5BLtEpB9 6WLMxaUzewUxJ09qzGukosYP1yvzhmXoNo8IX94Ah7/4sL93rwgLUbDx/mlQlhkvy72eW2Vl1EXLx usfBxWRnP4/ShtaMJMFA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfLMm-0002mV-Up; Mon, 24 Jun 2019 09:34:25 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfLMj-0002m4-QT; Mon, 24 Jun 2019 09:34:23 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5O9Y9ak098240; Mon, 24 Jun 2019 04:34:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1561368849; bh=mZ05HE4nNKGrw4LOWrgL5V2CUEn9P3ayZHfTAB4+wKg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=QHvgV1VBid3yfvAYfkInvcvUzsu7+ZRODUTEaCTWTngaBlgtIRSxJ4L4nju1mhQEf J0LicU6Jfmcy3XPGwTxj7vYA/MVdsC1vgwGI2NaFN+npupaECPNAPXZPF9SRq/FemX geZKyuh82gRY3fAARCadThvUr45hnPEHAEjwXy18= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5O9Y9pu040023 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Jun 2019 04:34:09 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 24 Jun 2019 04:34:08 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 24 Jun 2019 04:34:08 -0500 Received: from [172.24.190.89] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5O9Y4V9106204; Mon, 24 Jun 2019 04:34:05 -0500 Subject: Re: [PATCH v5 1/3] mtd: spi-nor: add support for is25wp256 To: Sagar Kadam References: <1560336476-31763-1-git-send-email-sagar.kadam@sifive.com> <1560336476-31763-2-git-send-email-sagar.kadam@sifive.com> <325855d0-00f9-df8a-ea57-c140d39dd6ef@ti.com> <93b9c5fd-8f59-96d7-5e40-2b9d540965dd@ti.com> From: Vignesh Raghavendra Message-ID: <3fe68154-5d1e-a395-4c53-d8e806b2cc6d@ti.com> Date: Mon, 24 Jun 2019 15:04:49 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_023421_967838_7080684E X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aou@eecs.berkeley.edu, tudor.ambarus@microchip.com, Wesley Terpstra , richard@nod.at, Palmer Dabbelt , linux-kernel@vger.kernel.org, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, Paul Walmsley , miquel.raynal@bootlin.com, linux-riscv@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi, On 21/06/19 3:58 PM, Sagar Kadam wrote: > Hello Vignesh, > > On Fri, Jun 21, 2019 at 11:33 AM Vignesh Raghavendra wrote: >> >> Hi, >> >> On 17/06/19 8:48 PM, Sagar Kadam wrote: >>> Hello Vignesh, >>> >>> Thanks for your review comments. >>> >>> On Sun, Jun 16, 2019 at 6:14 PM Vignesh Raghavendra wrote: >>>> >>>> Hi, >>>> >>>> On 12-Jun-19 4:17 PM, Sagar Shrikant Kadam wrote: >>>> [...] >>>> >>>>> @@ -4129,7 +4137,7 @@ int spi_nor_scan(struct spi_nor *nor, const char *name, >>>>> if (ret) >>>>> return ret; >>>>> >>>>> - if (nor->addr_width) { >>>>> + if (nor->addr_width && JEDEC_MFR(info) != SNOR_MFR_ISSI) { >>>>> /* already configured from SFDP */ >>>> >>>> Hmm, why would you want to ignore addr_width that's read from SFDP table? >>> >>> The SFDP table for ISSI device considered here, has addr_width set to >>> 3 byte, and the flash considered >>> here is 32MB. With 3 byte address width we won't be able to access >>> flash memories higher address range. >> >> Is it specific to a particular ISSI part as indicated here[1]? If so, >> please submit solution agreed there i.e. use spi_nor_fixups callback >> >> [1]https://patchwork.ozlabs.org/patch/1056049/ >> > > Thanks for sharing the link. > From what I understand here, it seems that "Address Bytes" of SFDP > table for the device under > consideration (is25lp256) supports 3 byte only Addressing mode > (DWORD1[18:17] = 0b00. > where as that of ISSI device (is25LP/WP 256Mb/512/Mb/1Gb) support 3 or > 4 byte Addressing mode DWORD1[18:17] = 0b01. > Okay, so that SFDP table entry is correct. SPI NOR framework should using 4 byte addressing if WORD1[18:17] = 0b01. Could you see if below diff helps: --->8--- diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index c0a8837c0575..ebf32aebe5e9 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2808,6 +2808,7 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor, break; case BFPT_DWORD1_ADDRESS_BYTES_4_ONLY: + case BFPT_DWORD1_ADDRESS_BYTES_3_OR_4: nor->addr_width = 4; break; -- Regards Vignesh ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/