From: "Edward A. Hildum" <ehildum@mail.arc.nasa.gov>
To: linux-mtd@lists.infradead.org
Subject: New interface to (old) JEDEC chips
Date: Tue, 18 Sep 2001 19:20:27 -0700 [thread overview]
Message-ID: <4.1.20010918183424.00a8fc20@mail.arc.nasa.gov> (raw)
Folks,
I'm working on a 586 SBC with 2Megs of flash (AM29F016) mapped into a
window in the 0xD0000 area. There is also some battery backed RAM mapped
nearby. Dwmw2 suggested I check out the probe_jedec.c code for accessing
the flash. Some comments:
In probe_jedec.c, jedec_probe_chip() :
1. I ran into a case where the code returned zeroes for both the
manufacturer ID and the chip ID (probably a bug in my low level driver).
The zeroes match the empty structure at the end of jedec_table[], so the
empty struct gets passed to cfi_jedec_init(). cfi_jedec_init() treats is
as a legit entry and happily builds some more structures. In any case the
empty struct isn't needed (at least by jedec_probe_chip() ). I deleted it
from my source.
2. The 'retried' variable is never incremented. If we hit the " if
(!retried ) ... " clause, we can get an infinite loop which screws the
machine tight. I've changed "if (!retried) ... " to "if (!retried++) ...".
Should it only retry once?
More as I figure out what I'm doing.
Ted Hildum
next reply other threads:[~2001-09-19 2:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-19 2:20 Edward A. Hildum [this message]
2001-09-19 21:28 ` New interface to (old) JEDEC chips David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4.1.20010918183424.00a8fc20@mail.arc.nasa.gov \
--to=ehildum@mail.arc.nasa.gov \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox