definition of CONFIG_MTD_DOCECC missing in drivers/mtd/devices/Config.in

definition of CONFIG_MTD_DOCECC missing in drivers/mtd/devices/Config.in

[Frantisek Rysanek]

[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 416 bytes --]

Dear MTD maintainers,

I've downloaded a "daily CVS snapshot" today:
mtd-snapshot-20040627.tar.bz2

I've noticed that CONFIG_MTD_DOCECC is missing
in $KERNEL_SRC_DIR/drivers/mtd/devices/Config.in,
which results in linker errors - unresolved
calls to doc_decode_ecc(), that is defined in docecc.c.

Attached is a suggested patch (I hope).

Have a nice day, thanks for the great job that you're doing.

Frank Rysanek


[-- Attachment #2: Attachment information. --]
[-- Type: text/plain, Size: 477 bytes --]

The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any other MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.

   ---- File information -----------
     File:  docecc.Config.in.patch
     Date:  28 Jun 2004, 8:31
     Size:  919 bytes.
     Type:  Binary

[-- Attachment #3: docecc.Config.in.patch --]
[-- Type: Application/Octet-stream, Size: 919 bytes --]

--- mtd/drivers/mtd/devices/Config.in	2003-05-29 00:00:10.000000000 +0200
+++ linux-2.4.26/drivers/mtd/devices/Config.in	2004-06-28 08:12:56.000000000 +0200
@@ -31,6 +31,9 @@
    dep_tristate '  M-Systems Disk-On-Chip 2000 and Millennium' CONFIG_MTD_DOC2000 $CONFIG_MTD
    dep_tristate '  M-Systems Disk-On-Chip Millennium-only alternative driver (see help)' CONFIG_MTD_DOC2001 $CONFIG_MTD
    dep_tristate '  M-Systems Disk-On-Chip Millennium Plus driver (see help)' CONFIG_MTD_DOC2001PLUS $CONFIG_MTD
+   if [ "$CONFIG_MTD_DOC2001PLUS" = "y" -o "$CONFIG_MTD_DOC2001" = "y" -o "$CONFIG_MTD_DOC2000" = "y" -o "$CONFIG_MTD_DOC2001PLUS" = "m" -o "$CONFIG_MTD_DOC2001" = "m" -o "$CONFIG_MTD_DOC2000" = "m" ]; then
+      define_bool CONFIG_MTD_DOCECC y
+   fi
    if [ "$CONFIG_MTD_DOC2001PLUS" = "y" -o "$CONFIG_MTD_DOC2001" = "y" -o "$CONFIG_MTD_DOC2000" = "y" ]; then
       define_bool CONFIG_MTD_DOCPROBE y
    else

Re: definition of CONFIG_MTD_DOCECC missing indrivers/mtd/devices/Config.in

[Dan Brown]

----- Original Message ----- 
From: "Frantisek Rysanek" <Frantisek.Rysanek@post.cz>
Sent: Monday, June 28, 2004 3:40 AM
Subject: definition of CONFIG_MTD_DOCECC missing
indrivers/mtd/devices/Config.in


> I've noticed that CONFIG_MTD_DOCECC is missing
> in $KERNEL_SRC_DIR/drivers/mtd/devices/Config.in,
> which results in linker errors - unresolved
> calls to doc_decode_ecc(), that is defined in docecc.c.
>
> Attached is a suggested patch (I hope).

Good catch; I forgot to add proper 2.4 support for this.  Sorry!  Fix
commited to CVS, should be in the next snapshot.

    -Dan Brown