Re: JFFS2 on NAND, Magic bitmask 0x1985 not found

Pathompong Puengrostham
2004-07-14T04:49:16Z

Hi,

I just found the problem. It is that my NAND flash CE pin is not driven
by GPIO. It is driven by CS from the CPU. Here is the change that I made.

--- mtd/drivers/mtd/nand/nand_base.c 2004-07-01 05:00:10.000000000 +0700
+++ linux/drivers/mtd/nand/nand_base.c 2004-07-14 11:32:37.419835456 +0700
@@ -990,8 +990,15 @@
* by an GPIO pin ?
*/
out:
+#ifdef CONFIG_MTD_NAND_CE_NOT_GPIO
+ if (!this->dev_ready)
+ udelay (this->chip_delay);
+ else
+ while (!this->dev_ready(mtd));
+#else
this->select_chip(mtd, -1);
this->select_chip(mtd, chipnr);
+#endif
return res;
}
#endif
@@ -1248,8 +1255,15 @@
} else
read += mtd->oobblock;

- if (read == len)
+ if (read == len) {
+#ifdef CONFIG_MTD_NAND_CE_NOT_GPIO
+ if (!this->dev_ready)
+ udelay (this->chip_delay);
+ else
+ while (!this->dev_ready(mtd));
+#endif
break;
+ }

/* For subsequent reads align to page boundary. */
col = 0;
@@ -1374,6 +1388,14 @@
this->cmdfunc (mtd, NAND_CMD_READOOB, 0x0, page &
this->pagemask);
}
}
+#ifdef CONFIG_MTD_NAND_CE_NOT_GPIO
+ else {
+ if (!this->dev_ready)
+ udelay (this->chip_delay);
+ else
+ while (!this->dev_ready(mtd));
+ }
+#endif
}

/* Deselect and wake up anyone waiting on the device */

I also had to add the following to my nand_init().

for (i = 0; nand_flash_ids[i].name != NULL; i++)
nand_flash_ids[i].options |= NAND_NO_AUTOINCR;

Regards,
Jay

Pathompong Puengrostham wrote:
> Hi all,
>
> Could anybody help me on this please? I mounted a cleanly erased NAND
> flash , unmounted without writing anything into it and then mounted it
> again. I got the following errors.
>
> nand_read_ecc: Failed ECC read, page 0x000000e0
> mtd->read(0x400 bytes from 0x1c000) returned ECC error
> jffs2_scan_eraseblock(): Node at 0x0001c008 {0x1985, 0x2003, 0x00000008)
> has invalid CRC 0xffff0000 (calculated 0x6b7c27e6)
> jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x0001c00c:
> 0x0008 instead
> nand_read_ecc: Failed ECC read, page 0x00000120
> mtd->read(0x400 bytes from 0x24000) returned ECC error
> jffs2_scan_eraseblock(): Node at 0x00024008 {0x1985, 0x2003, 0x00000008)
> has invalid CRC 0xffff0000 (calculated 0x6b7c27e6)
> jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x0002400c:
> 0x0008 instead
> ...
>
> This is the data that I dump out of the flash using "nanddump /dev/mtd3
> dump.txt 114688 1024"
>
> 0x0001c000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> 0x0001c010: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> ...
> 0x0001c1f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> OOB Data: ff ff ff ff ff ff ff ff 85 19 03 20 08 00 00 00
> 0x0001c200: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> 0x0001c210: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> ...
> 0x0001c3f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> OOB Data: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>
> I can see that the magic bitmask 0x1985 is there. Why did JFFS2 look at
> the wrong place and got 0x0008 instead?
>
> I'm using mtd snapshot 20040707.
>
> Thank you in advance.
>
> Regards,
> Jay
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
>