* [PATCH] mtd: nand: atmel: Fix EDO mode check
@ 2017-07-31 8:32 Boris Brezillon
2017-07-31 11:54 ` Alexander Dahl
2017-07-31 16:28 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-07-31 8:32 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, linux-mtd
Cc: David Woodhouse, Brian Norris, Marek Vasut, Cyrille Pitchen,
Alexander Dahl, Nicolas Ferre, Alexandre Belloni
EDO mode should be used when tRC is less than 30ns, but timings are
expressed in picoseconds in the nand_sdr_timings struct.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Fixes: f9ce2eddf176 ("mtd: nand: atmel: Add ->setup_data_interface() hooks")
Reported-by: Alexander Dahl <ada@thorsis.com>
---
drivers/mtd/nand/atmel/nand-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
index d922a88e407f..2c8baa0c2c4e 100644
--- a/drivers/mtd/nand/atmel/nand-controller.c
+++ b/drivers/mtd/nand/atmel/nand-controller.c
@@ -1201,7 +1201,7 @@ static int atmel_smc_nand_prepare_smcconf(struct atmel_nand *nand,
* tRC < 30ns implies EDO mode. This controller does not support this
* mode.
*/
- if (conf->timings.sdr.tRC_min < 30)
+ if (conf->timings.sdr.tRC_min < 30000)
return -ENOTSUPP;
atmel_smc_cs_conf_init(smcconf);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: atmel: Fix EDO mode check
2017-07-31 8:32 [PATCH] mtd: nand: atmel: Fix EDO mode check Boris Brezillon
@ 2017-07-31 11:54 ` Alexander Dahl
2017-07-31 16:28 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Dahl @ 2017-07-31 11:54 UTC (permalink / raw)
To: linux-mtd
Cc: Boris Brezillon, Richard Weinberger, Nicolas Ferre, Marek Vasut,
Alexandre Belloni, Cyrille Pitchen, Brian Norris, David Woodhouse
Hello,
Tested-by: Alexander Dahl <ada@thorsis.com>
Greets
Alex
Am Montag, 31. Juli 2017, 10:32:21 schrieb Boris Brezillon:
> EDO mode should be used when tRC is less than 30ns, but timings are
> expressed in picoseconds in the nand_sdr_timings struct.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Fixes: f9ce2eddf176 ("mtd: nand: atmel: Add ->setup_data_interface()
> hooks") Reported-by: Alexander Dahl <ada@thorsis.com>
> ---
> drivers/mtd/nand/atmel/nand-controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c
> b/drivers/mtd/nand/atmel/nand-controller.c index
> d922a88e407f..2c8baa0c2c4e 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -1201,7 +1201,7 @@ static int atmel_smc_nand_prepare_smcconf(struct
> atmel_nand *nand, * tRC < 30ns implies EDO mode. This controller does
> not support this * mode.
> */
> - if (conf->timings.sdr.tRC_min < 30)
> + if (conf->timings.sdr.tRC_min < 30000)
> return -ENOTSUPP;
>
> atmel_smc_cs_conf_init(smcconf);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: atmel: Fix EDO mode check
2017-07-31 8:32 [PATCH] mtd: nand: atmel: Fix EDO mode check Boris Brezillon
2017-07-31 11:54 ` Alexander Dahl
@ 2017-07-31 16:28 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-07-31 16:28 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, linux-mtd
Cc: David Woodhouse, Brian Norris, Marek Vasut, Cyrille Pitchen,
Alexander Dahl, Nicolas Ferre, Alexandre Belloni
On Mon, 31 Jul 2017 10:32:21 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> EDO mode should be used when tRC is less than 30ns, but timings are
> expressed in picoseconds in the nand_sdr_timings struct.
Applied to nand/fixes.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Fixes: f9ce2eddf176 ("mtd: nand: atmel: Add ->setup_data_interface() hooks")
> Reported-by: Alexander Dahl <ada@thorsis.com>
> ---
> drivers/mtd/nand/atmel/nand-controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index d922a88e407f..2c8baa0c2c4e 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -1201,7 +1201,7 @@ static int atmel_smc_nand_prepare_smcconf(struct atmel_nand *nand,
> * tRC < 30ns implies EDO mode. This controller does not support this
> * mode.
> */
> - if (conf->timings.sdr.tRC_min < 30)
> + if (conf->timings.sdr.tRC_min < 30000)
> return -ENOTSUPP;
>
> atmel_smc_cs_conf_init(smcconf);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-31 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-31 8:32 [PATCH] mtd: nand: atmel: Fix EDO mode check Boris Brezillon
2017-07-31 11:54 ` Alexander Dahl
2017-07-31 16:28 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox