public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* Suspend problem on 2.6.x
@ 2004-10-01 11:23 Ben Dooks
  2004-10-01 18:29 ` Todd Poynor
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2004-10-01 11:23 UTC (permalink / raw)
  To: linux-mtd

mtdblockd when running on 2.6 is either ignorning or
not dealing with the suspend-to-memory request, and therefore
the system is not shutting down when asked to.

bash-2.05a# echo mem > /sys/power/state
Stopping tasks: ==
 stopping tasks failed (1 tasks remaining)
Restarting tasks...<6> Strange, mtdblockd not stopped
 done
bash-2.05a#

I have worked round this for the moment by
adding PF_NOFREEZE to the current->flags at the start of 
mtd_bldevs.c:mtd_blktrans_thread()

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Suspend problem on 2.6.x
  2004-10-01 11:23 Suspend problem on 2.6.x Ben Dooks
@ 2004-10-01 18:29 ` Todd Poynor
  0 siblings, 0 replies; 2+ messages in thread
From: Todd Poynor @ 2004-10-01 18:29 UTC (permalink / raw)
  To: Ben Dooks; +Cc: linux-mtd

Ben Dooks wrote:
> mtdblockd when running on 2.6 is either ignorning or
> not dealing with the suspend-to-memory request, and therefore
> the system is not shutting down when asked to.
> 
> bash-2.05a# echo mem > /sys/power/state
> Stopping tasks: ==
>  stopping tasks failed (1 tasks remaining)
> Restarting tasks...<6> Strange, mtdblockd not stopped
>  done
> bash-2.05a#
> 
> I have worked round this for the moment by
> adding PF_NOFREEZE to the current->flags at the start of 
> mtd_bldevs.c:mtd_blktrans_thread()

Right, this same fix was committed to infradead cvs a few weeks ago.  It 
is the freeze execution signal that is being ignored (the thread does 
not enable or poll for such signals).  Since mtdblockd/ftld might need 
to perform I/O to save state during a suspend, and since these probably 
doesn't need to access resources that are impaired during the state save 
phase, exempting these from execution freeze via PF_NOFREEZE seems the 
right solution.

-- 
Todd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-01 18:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-01 11:23 Suspend problem on 2.6.x Ben Dooks
2004-10-01 18:29 ` Todd Poynor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox