public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Steven Scholz <steven.scholz@imc-berlin.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Bug in cfi_cmdset_0002.c in linux-2.6.8.1
Date: Thu, 11 Nov 2004 17:10:57 +0100	[thread overview]
Message-ID: <41938F11.3040903@imc-berlin.de> (raw)
In-Reply-To: <MKELJOLMMOHJCMIPKLJKCEMOCAAA.j.karrer@lightmaze.com>

Jochen Karrer wrote:
> Hi,
> jffs2 did not work in linux-2.6.8.1 because single word writes at the end
> of a buffer write are done with the wrong address:
> 
> --- /home/jkarrer/kernel/linux-2.6.8.1/drivers/mtd/chips/cfi_cmdset_0002.c
> Sat Aug 14 12:55:20 2004
> +++ cfi_cmdset_0002.c	Thu Aug 26 14:33:42 2004
> @@ -1128,7 +1128,7 @@
>  	if (len) {
>  		size_t retlen_dregs = 0;
> 
> -		ret = cfi_amdstd_write_words(mtd, to, len, &retlen_dregs, buf);
> +		ret = cfi_amdstd_write_words(mtd, ofs + (chipnum<<cfi->chipshift), len,
> &retlen_dregs, buf);
> 
>  		*retlen += retlen_dregs;
>  		return ret;

As far as I can see this bug is still not fixed in 2.6.9!
Is it done in newer versions?

--
Steven

  parent reply	other threads:[~2004-11-11 16:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-26 13:11 Bug in cfi_cmdset_0002.c in linux-2.6.8.1 Jochen Karrer
2004-08-26 14:02 ` Steven Scholz
2004-08-26 14:12 ` David Woodhouse
2004-08-26 14:48   ` Jochen Karrer
2004-09-14 19:41 ` Thayne Harbaugh
2004-09-14 20:47   ` David Woodhouse
2004-09-15 17:19     ` Thayne Harbaugh
2004-09-15 17:41       ` David Woodhouse
2004-09-15 23:34     ` Thayne Harbaugh
2004-09-15  8:16   ` Manfred Gruber
2004-11-11 16:10 ` Steven Scholz [this message]
2004-11-11 17:45   ` Thayne Harbaugh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41938F11.3040903@imc-berlin.de \
    --to=steven.scholz@imc-berlin.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox