From: Artem Bityuckiy <dedekind@oktetlabs.ru>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Garbage collect pristine nodes
Date: Fri, 12 Nov 2004 18:35:33 +0300 [thread overview]
Message-ID: <4194D845.7070607@oktetlabs.ru> (raw)
In-Reply-To: <1100272904.21273.193.camel@baythorne.infradead.org>
David Woodhouse wrote:
> On Fri, 2004-11-12 at 18:06 +0300, Artem Bityuckiy wrote:
>
>>We allocate sizeof(struct jffs2_raw_inode) + JFFS2_MIN_DATA_LEN which is
>> only 68 + 128 bytes. But the maximum size of direntry is more than
>>245 bytes. So, if few bytes were allocated (alloclen < rawlen) and this
>>is just direntry with long name, we Garbage Collect it using long path
>>(which is unneeded).
>
>
> How often does this _actually_ happen? Remember, alloclen tells us how
> much space is _available_ -- it could be larger than the amount we asked
> for. So we'll only take the long route if the name in the dirent is
> large _and_ it wouldn't actually fit in the end of the eraseblock.
>
Hmm, you are right.
Forget about this :-)
--
Best regards, Artem B. Bityuckiy
Oktet Labs (St. Petersburg), Software Engineer.
+78124286709 (office) +79112449030 (mobile)
E-mail: dedekind@oktetlabs.ru, web: http://www.oktetlabs.ru
prev parent reply other threads:[~2004-11-12 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 15:06 Garbage collect pristine nodes Artem Bityuckiy
2004-11-12 15:21 ` David Woodhouse
2004-11-12 15:35 ` Artem Bityuckiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4194D845.7070607@oktetlabs.ru \
--to=dedekind@oktetlabs.ru \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox