* remove the 'totlen' field from node_ref
@ 2004-11-15 9:03 Artem B. Bityuckiy
2004-11-15 9:18 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: Artem B. Bityuckiy @ 2004-11-15 9:03 UTC (permalink / raw)
To: linux-mtd
Hello,
I see there were efforts to remove the 'totlen' field from the
jffs2_raw_node_ref structure. But it is not done yet.
As I understand, in order to succesfullt done this improvements, all the
space in flash must be represented by means of nodes. This means, we
should keep padding node references (jffs2_raw_node_ref for paddigs)
in-core too.
Why is this work not done yet? Are there some difficulties? May be some
problems arise when we pad to the end of NAND page/Flash block but the
padding length is not sufficient to write the padding node and we just
write some pattern?
Thanks.
--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: remove the 'totlen' field from node_ref
2004-11-15 9:03 remove the 'totlen' field from node_ref Artem B. Bityuckiy
@ 2004-11-15 9:18 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2004-11-15 9:18 UTC (permalink / raw)
To: Artem B. Bityuckiy; +Cc: linux-mtd
On Mon, 2004-11-15 at 12:03 +0300, Artem B. Bityuckiy wrote:
> Hello,
>
> I see there were efforts to remove the 'totlen' field from the
> jffs2_raw_node_ref structure. But it is not done yet.
>
> As I understand, in order to succesfullt done this improvements, all the
> space in flash must be represented by means of nodes. This means, we
> should keep padding node references (jffs2_raw_node_ref for paddigs)
> in-core too.
Correct.
> Why is this work not done yet? Are there some difficulties? May be some
> problems arise when we pad to the end of NAND page/Flash block but the
> padding length is not sufficient to write the padding node and we just
> write some pattern?
No, that's not a problem. We can quite happily keep a raw_node_ref which
describes that, and we can do so at mount time too. Mostly we just need
to fix the mount code to generate obsolete node refs for dirty space
rather than just ignoring it and moving on.
Doing that alone is fairly simple. The main reason I haven't done it yet
is because it would need a _lot_ of testing, probably with a period of
checking against the real __totlen field and complaining if they differ.
I haven't really had enough time to do the amount of testing I'd like
before I release such a change.
--
dwmw2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-15 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-15 9:03 remove the 'totlen' field from node_ref Artem B. Bityuckiy
2004-11-15 9:18 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox