From: Estelle HAMMACHE <estelle.hammache@st.com>
To: linux-mtd@lists.infradead.org
Subject: Re: JFFS2 & NAND failure
Date: Wed, 15 Dec 2004 13:33:45 +0100 [thread overview]
Message-ID: <41C02F29.92D2B5A@st.com> (raw)
In-Reply-To: 41B88622.4BCD78EC@st.com
Hi everyone,
it seems there is a problem with jffs2_wbuf_recover and
the wbuf_sem...
jffs2_flash_writev
** down_write(&c->wbuf_sem); !!!
** __jffs2_flush_wbuf
**** jffs2_wbuf_recover
****** jffs2_block_refile
******** nextblock = NULL;
****** jffs2_reserve_space_gc
******** jffs2_do_reserve_space
********** jffs2_erase_pending_blocks
************ jffs2_mark_erased_block
************** jffs2_flash_read
**************** down_read(&c->wbuf_sem); !!!
I believe that when checking a newly erased block, the
wbuf should not be used anyway, so this is probably easy to
correct. Is it ok to create a jffs2_flash_read_nobuf function
and call it only from jffs2_mark_erased_block ?
Also, still looking at the same recovery scheme, I believe
the following could happen if there are no free or erasing
blocks (but is it really possible ???)
jffs2_flash_writev
** __jffs2_flush_wbuf
**** jffs2_wbuf_recover
****** jffs2_block_refile
******** nextblock = NULL;
****** jffs2_reserve_space_gc
******** jffs2_do_reserve_space
********** jffs2_flush_wbuf_pad
************ __jffs2_flush_wbuf
bye
Estelle
next prev parent reply other threads:[~2004-12-15 12:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 17:15 JFFS2 & NAND failure Estelle HAMMACHE
2004-11-18 16:27 ` David Woodhouse
2004-11-18 17:54 ` Estelle HAMMACHE
2004-11-19 13:17 ` David Woodhouse
2004-11-19 16:22 ` Estelle HAMMACHE
2004-11-20 18:57 ` David Woodhouse
2004-11-20 19:19 ` David Woodhouse
2004-11-20 22:13 ` David Woodhouse
2004-12-09 14:57 ` David Woodhouse
2004-12-09 17:06 ` Estelle HAMMACHE
2004-12-15 12:33 ` Estelle HAMMACHE [this message]
2005-02-02 16:21 ` Estelle HAMMACHE
2005-04-04 12:58 ` Artem B. Bityuckiy
2005-04-04 13:58 ` Estelle HAMMACHE
2005-04-04 14:47 ` Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C02F29.92D2B5A@st.com \
--to=estelle.hammache@st.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox