From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>, <broonie@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<andersson@kernel.org>, <konradybcio@kernel.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<manivannan.sadhasivam@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>
Cc: <quic_srichara@quicinc.com>, <quic_varada@quicinc.com>
Subject: Re: [PATCH v12 4/8] mtd: nand: Add qpic_common API file
Date: Mon, 21 Oct 2024 11:19:34 -0700 [thread overview]
Message-ID: <41db541a-4de1-409b-bfec-7b9456fc200f@quicinc.com> (raw)
In-Reply-To: <20241021115620.1616617-5-quic_mdalam@quicinc.com>
On 10/21/24 04:56, Md Sadre Alam wrote:
...
> diff --git a/drivers/mtd/nand/qpic_common.c b/drivers/mtd/nand/qpic_common.c
> new file mode 100644
> index 000000000000..570ab59ca12b
> --- /dev/null
> +++ b/drivers/mtd/nand/qpic_common.c
> @@ -0,0 +1,757 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
I'm surprised you aren't adding a 2024 Qualcomm Innovation Center copyright
...
> +MODULE_LICENSE("GPL");
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Recently, multiple
developers have been eradicating these warnings treewide, and very few
(if any) are left, so please don't introduce a new one :)
Please add the missing MODULE_DESCRIPTION()
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-10-21 18:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 11:56 [PATCH v12 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-10-21 11:56 ` [PATCH v12 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-10-21 11:56 ` [PATCH v12 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-10-21 11:56 ` [PATCH v12 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-10-26 11:45 ` Konrad Dybcio
2024-10-21 11:56 ` [PATCH v12 4/8] mtd: nand: Add qpic_common API file Md Sadre Alam
2024-10-21 18:19 ` Jeff Johnson [this message]
2024-10-22 4:39 ` Md Sadre Alam
2024-10-25 18:27 ` Jeff Johnson
2024-10-29 4:16 ` Md Sadre Alam
2024-10-21 11:56 ` [PATCH v12 5/8] mtd: rawnand: qcom: use FIELD_PREP and GENMASK Md Sadre Alam
2024-10-25 18:13 ` Konrad Dybcio
2024-10-21 11:56 ` [PATCH v12 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-10-25 16:08 ` kernel test robot
2024-10-25 18:14 ` Konrad Dybcio
2024-10-29 4:15 ` Md Sadre Alam
2024-10-21 11:56 ` [PATCH v12 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-10-21 11:56 ` [PATCH v12 8/8] arm64: dts: qcom: ipq9574: Remove eMMC node Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41db541a-4de1-409b-bfec-7b9456fc200f@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=quic_mdalam@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox