public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Mohammad Rahimi <rahimi.mhmmd@gmail.com>,
	<david.oberhollenzer@sigma-star.at>
Cc: <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] ubiattach: fix wording in usage example
Date: Thu, 12 Feb 2026 11:15:56 +0800	[thread overview]
Message-ID: <41f7b452-5d9d-5bca-62db-8b997ce3ed1f@huawei.com> (raw)
In-Reply-To: <20260212013542.22699-1-rahimi.mhmmd@gmail.com>

在 2026/2/12 9:35, Mohammad Rahimi 写道:
> The usage example 4 describing reserved eraseblocks had awkward and
> slightly incorrect phrasing ("is total flash chip eraseblocks count").
> Reword it for clarity and readability without changing the meaning.
> 
> Signed-off-by: Mohammad Rahimi <rahimi.mhmmd@gmail.com>
> ---
>   ubi-utils/ubiattach.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> 
> diff --git a/ubi-utils/ubiattach.c b/ubi-utils/ubiattach.c
> index e758dab..11e171b 100644
> --- a/ubi-utils/ubiattach.c
> +++ b/ubi-utils/ubiattach.c
> @@ -92,9 +92,9 @@ static const char usage[] =
>   "           and create UBI device number 3 (ubi3)\n"
>   "Example 4: " PROGRAM_NAME " -m 1 -b 25 - attach /dev/mtd1 to UBI and reserve\n"
>   "           25*C/1024 eraseblocks for bad block handling, where C is the flash\n"
> -"           is total flash chip eraseblocks count, that is flash chip size in\n"
> -"           eraseblocks (including bad eraseblocks). E.g., if the flash chip\n"
> -"           has 4096 PEBs, 100 will be reserved.";
> +"           chip total eraseblocks count, that is flash chip size in eraseblocks\n"
> +"           (including bad eraseblocks). E.g., if the flash chip has 4096 PEBs,\n"
> +"           100 will be reserved.";
>   
>   static const struct option long_options[] = {
>   	{ .name = "devn",            .has_arg = 1, .flag = NULL, .val = 'd' },
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2026-02-12  3:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12  1:35 [PATCH] ubiattach: fix wording in usage example Mohammad Rahimi
2026-02-12  3:15 ` Zhihao Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41f7b452-5d9d-5bca-62db-8b997ce3ed1f@huawei.com \
    --to=chengzhihao1@huawei.com \
    --cc=david.oberhollenzer@sigma-star.at \
    --cc=linux-mtd@lists.infradead.org \
    --cc=rahimi.mhmmd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox