* [PATCH] duplicate assignment in map_ram.c
@ 2001-08-02 20:51 Eric
2001-08-07 10:08 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: Eric @ 2001-08-02 20:51 UTC (permalink / raw)
To: linux-mtd
dwmw2, et. al.,
There's a duplicate assignment to mtd->erasesize in
<mtd>/drivers/mtd/chips/map_ram.c which is removed
with the following patch. I've assumed that the later
assignment is the one you wish to keep-- this may not
be the correct assumption.
E
Index: map_ram.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/chips/map_ram.c,v
retrieving revision 1.12
diff -u -r1.12 map_ram.c
--- map_ram.c 2001/07/14 00:59:17 1.12
+++ map_ram.c 2001/08/02 20:52:38
@@ -63,7 +63,6 @@
mtd->priv = map;
mtd->name = map->name;
mtd->type = MTD_RAM;
- mtd->erasesize = 0x10000;
mtd->size = map->size;
mtd->erase = mapram_erase;
mtd->read = mapram_read;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] duplicate assignment in map_ram.c
2001-08-02 20:51 [PATCH] duplicate assignment in map_ram.c Eric
@ 2001-08-07 10:08 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2001-08-07 10:08 UTC (permalink / raw)
To: Eric; +Cc: linux-mtd
ebrower@usa.net said:
> There's a duplicate assignment to mtd->erasesize in <mtd>/drivers/mtd/
> chips/map_ram.c which is removed with the following patch.
Applied, along with the following:
mtd->erasesize = PAGE_SIZE;
+ while(mtd->size & (mtd->erasesize - 1))
+ mtd->erasesize >>= 1;
Thanks.
--
dwmw2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-08-07 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-08-02 20:51 [PATCH] duplicate assignment in map_ram.c Eric
2001-08-07 10:08 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox