From: Dan Brown <dan_brown@ieee.org>
To: Zeri Virgo <zerivirgo@infocell-its.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [UPDATE] DOCBoot support for NFTL-based DOC2000
Date: Mon, 04 Apr 2005 14:04:23 -0400 [thread overview]
Message-ID: <425181A7.2010809@ieee.org> (raw)
In-Reply-To: <425157C5.4040007@infocell-its.com>
Zeri Virgo wrote:
> The call stack goes from mtd->read into nand_base.c nand_read() then
> nand_do_read_ecc() passing NULL to oob_buf and oob_sel. The pointer
> dereference occurs on oobsel when defining ecc_calc and ecc_code... I
> (nervously) replaced these with hard values and the probing completed
> successfully. I think most of the activity lower down does null checks
> on oobsel or doesn't use these values due to the eccmode.
>
> I have no idea what the fix should be! Maybe move the definitions of
> ecc_calc and ecc_code below the check and set of oobsel to &mtd->oobinfo?
You're 100% correct. A recent modification to support variable-sized
ecc_calc and ecc_code arrays didn't take into account the possibility of
NULL oobsel. Fixed in CVS.
Let me know if DOCBoot finally works for you, please!
-Dan
next prev parent reply other threads:[~2005-04-04 18:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 21:06 [UPDATE] DOCBoot support for NFTL-based DOC2000 Dan Brown
2005-03-31 15:50 ` Zeri Virgo
2005-03-31 20:35 ` Dan Brown
2005-04-01 1:33 ` Zeri Virgo
2005-04-01 2:13 ` Dan Brown
2005-04-04 15:05 ` Zeri Virgo
2005-04-04 18:04 ` Dan Brown [this message]
2005-04-05 12:00 ` Zeri Virgo
2005-04-05 19:51 ` Dan Brown
2005-04-06 12:13 ` Zeri Virgo
2005-04-06 12:29 ` Zeri Virgo
2005-04-06 13:12 ` Dan Brown
2005-04-06 14:48 ` Zeri Virgo
2005-04-06 16:29 ` Dan Brown
2005-04-06 18:23 ` Dan Brown
2005-04-07 14:27 ` Dan Brown
2005-04-07 21:45 ` Zeri Virgo
2005-04-08 15:41 ` Dan Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425181A7.2010809@ieee.org \
--to=dan_brown@ieee.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zerivirgo@infocell-its.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox