Re: [UPDATE] DOCBoot support for NFTL-based DOC2000

Dan Brown
2005-04-04T18:04:37Z

Zeri Virgo wrote:

> The call stack goes from mtd->read into nand_base.c nand_read() then
> nand_do_read_ecc() passing NULL to oob_buf and oob_sel. The pointer
> dereference occurs on oobsel when defining ecc_calc and ecc_code... I
> (nervously) replaced these with hard values and the probing completed
> successfully. I think most of the activity lower down does null checks
> on oobsel or doesn't use these values due to the eccmode.
>
> I have no idea what the fix should be! Maybe move the definitions of
> ecc_calc and ecc_code below the check and set of oobsel to &mtd->oobinfo?

You're 100% correct. A recent modification to support variable-sized
ecc_calc and ecc_code arrays didn't take into account the possibility of
NULL oobsel. Fixed in CVS.

Let me know if DOCBoot finally works for you, please!

-Dan