From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Michael Walle <michael@walle.cc>
Cc: Jaime Liao <jaimeliao.tw@gmail.com>,
linux-mtd@lists.infradead.org, pratyush@kernel.org,
miquel.raynal@bootlin.com, leoyu@mxic.com.tw,
JaimeLiao <jaimeliao@mxic.com.tw>
Subject: Re: [PATCH v2 2/2] mtd: spi-nor: add support for Macronix Octal flash
Date: Thu, 27 Jul 2023 11:10:46 +0100 [thread overview]
Message-ID: <42731f09-e198-24b1-c293-c383dd706c10@linaro.org> (raw)
In-Reply-To: <ef91b41242da72c4bf6b5e3bed9862d5@walle.cc>
On 7/27/23 11:04, Michael Walle wrote:
> Hi,
>
>>> + { "mx66uw2g345gx0", INFOB(0xc2943c, 0, 0, 0, 4)
>>> + FLAGS(SPI_NOR_RWW)
>>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_READ | SPI_NOR_OCTAL_DTR_READ |
>>> + SPI_NOR_OCTAL_DTR_PP) },
>>> + { "mx25uw51345g", INFOB(0xc2843a, 0, 0, 0, 4)
>>> + FLAGS(SPI_NOR_RWW)
>>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_OCTAL_DTR_PP) },
>>> + { "mx25um25345g", INFO(0xc28339, 0, 0, 0)
>>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_OCTAL_DTR_PP) },
>>> + { "mx25uw25345g", INFOB(0xc28439, 0, 0, 0, 4)
>>> + FLAGS(SPI_NOR_RWW)
>>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_OCTAL_DTR_PP) },
>>> + { "mx25uw12345g", INFOB(0xc28438, 0, 0, 0, 4)
>>> + FLAGS(SPI_NOR_RWW)
>>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_OCTAL_DTR_PP) },
>>> + { "mx25uw6345g", INFOB(0xc28437, 0, 0, 0, 4)
>>> + FLAGS(SPI_NOR_RWW)
>>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_OCTAL_DTR_PP) },
>>
>> PARSE_SFDP for all the flashes please.
>
> And no NO_SFDP_FLAGS() as discussed.
>
Are there flavors of these flashes that don't support SFDP,
or why did you ask for NO_SFDP_FLAGS? Do each of these flashes
have SFDP and no-SFDP flavors?
If that's the case, I'm not yet sure if we want to mix PARSE_SFDP
with NO_SFDP_FLAGS().
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-07-27 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 9:16 [PATCH v2 0/2] Add octal DTR support for Macronix flash Jaime Liao
2023-07-27 9:16 ` [PATCH v2 1/2] mtd: spi-nor: add Octal " Jaime Liao
2023-07-27 10:00 ` Tudor Ambarus
2023-07-27 10:04 ` Tudor Ambarus
2023-07-27 10:11 ` Michael Walle
2023-07-28 9:46 ` Michael Walle
2023-07-28 11:01 ` Tudor Ambarus
2023-08-01 7:24 ` liao jaime
2023-08-01 8:16 ` Tudor Ambarus
2023-08-01 9:33 ` liao jaime
2023-07-27 9:16 ` [PATCH v2 2/2] mtd: spi-nor: add support for Macronix Octal flash Jaime Liao
2023-07-27 9:54 ` Tudor Ambarus
2023-07-27 10:04 ` Michael Walle
2023-07-27 10:10 ` Tudor Ambarus [this message]
2023-07-27 10:12 ` Michael Walle
2023-07-27 10:14 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42731f09-e198-24b1-c293-c383dd706c10@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=jaimeliao.tw@gmail.com \
--cc=jaimeliao@mxic.com.tw \
--cc=leoyu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox