From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-block <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-mtd@lists.infradead.org, Pavel Machek <pavel@ucw.cz>,
Paolo Valente <paolo.valente@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Richard Weinberger <richard@nod.at>,
Adrian Hunter <adrian.hunter@intel.com>,
Bart Van Assche <bvanassche@acm.org>, Jan Kara <jack@suse.cz>,
Artem Bityutskiy <dedekind1@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Mark Brown <broonie@kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v2] block: BFQ default for single queue devices
Date: Fri, 19 Oct 2018 11:26:37 +0200 [thread overview]
Message-ID: <42fc6a366e88335b72517ea7d58847fd@natalenko.name> (raw)
In-Reply-To: <CACRpkdZgethKLu3P4taLfzqjGULyoP-T7bhUUpRKtjDRteNnxA@mail.gmail.com>
Hi.
On 19.10.2018 10:33, Linus Walleij wrote:
>> > + /*
>> > + * Zoned devices must use a deadline scheduler because currently
>> > + * that is the only scheduler respecting zoned writes.
>> > + */
>> > + if (blk_queue_is_zoned(q))
>> > + policy = "mq-deadline";
>> > + else if (IS_ENABLED(CONFIG_IOSCHED_BFQ))
>> > + policy = "bfq";
>> > + else
>> > + policy = "mq-deadline";
>>
>> If more rules will be needed in the future, shall we just add extra
>> ifs,
>> or it would be better to craft some struct/table now + policy search
>> helper?
>
> Let's do it when it happens. Premature optimization is the root
> of all evil ;)
I'd say, this is a matter of code readability, not optimisations. I do
not strongly object against current approach, though.
--
Oleksandr Natalenko (post-factum)
next prev parent reply other threads:[~2018-10-19 9:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 14:10 [PATCH v2] block: BFQ default for single queue devices Linus Walleij
2018-10-15 14:22 ` Paolo Valente
2018-10-15 14:32 ` Oleksandr Natalenko
2018-10-19 8:33 ` Linus Walleij
2018-10-19 9:26 ` Oleksandr Natalenko [this message]
2018-10-15 15:02 ` Bart Van Assche
2018-10-15 18:34 ` Paolo Valente
2018-10-17 5:18 ` Paolo Valente
2018-10-16 16:14 ` Federico Motta
2018-10-16 16:26 ` Paolo Valente
2018-10-15 15:39 ` Jens Axboe
2018-10-15 18:26 ` Paolo Valente
2018-10-15 19:26 ` Jens Axboe
2018-10-15 19:44 ` Paolo Valente
2018-10-16 17:35 ` Jens Axboe
2018-10-17 10:05 ` Jan Kara
2018-10-17 14:48 ` Bart Van Assche
2018-10-17 14:59 ` Bryan Gurney
2018-10-19 8:42 ` Linus Walleij
2018-10-19 13:36 ` Bryan Gurney
2018-10-19 13:44 ` Johannes Thumshirn
2018-10-19 14:16 ` Bryan Gurney
2018-10-22 8:12 ` Jens Axboe
2018-10-17 16:01 ` Mark Brown
2018-10-17 16:29 ` Jens Axboe
2018-10-18 7:21 ` Jan Kara
2018-10-18 14:35 ` Jens Axboe
2018-10-19 8:22 ` Pavel Machek
2018-10-22 8:08 ` Jens Axboe
2018-11-02 10:40 ` Oleksandr Natalenko
2018-10-19 10:59 ` Paolo Valente
2018-10-22 8:21 ` Jens Axboe
2018-10-16 13:42 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42fc6a366e88335b72517ea7d58847fd@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=Damien.LeMoal@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=dedekind1@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=paolo.valente@linaro.org \
--cc=pavel@ucw.cz \
--cc=richard@nod.at \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox