* Should we put jffs2_sum_marker into eraseblock_header?
@ 2005-09-13 10:39 zhao forrest
2005-09-13 10:42 ` Artem B. Bityuckiy
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: zhao forrest @ 2005-09-13 10:39 UTC (permalink / raw)
To: linux-mtd
Hi,
When writing the eraseblock_header patch, I found the current
summary patch in MTD CVS place jffs2_sum_marker at the end of
each erase block. Since jffs2_sum_marker is a per-eraseblock
structure, should we put it into eraseblock_header when the
eraseblock_header patch is ready in the future?
Thanks,
Forrest
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Should we put jffs2_sum_marker into eraseblock_header?
2005-09-13 10:39 Should we put jffs2_sum_marker into eraseblock_header? zhao forrest
@ 2005-09-13 10:42 ` Artem B. Bityuckiy
2005-09-13 10:46 ` Jörn Engel
2005-09-13 11:59 ` Ferenc Havasi
2 siblings, 0 replies; 4+ messages in thread
From: Artem B. Bityuckiy @ 2005-09-13 10:42 UTC (permalink / raw)
To: zhao forrest; +Cc: linux-mtd
zhao forrest wrote:
> Hi,
>
> When writing the eraseblock_header patch, I found the current
> summary patch in MTD CVS place jffs2_sum_marker at the end of
> each erase block. Since jffs2_sum_marker is a per-eraseblock
> structure, should we put it into eraseblock_header when the
> eraseblock_header patch is ready in the future?
>
Yes, it ought to go there IMO.
--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Should we put jffs2_sum_marker into eraseblock_header?
2005-09-13 10:39 Should we put jffs2_sum_marker into eraseblock_header? zhao forrest
2005-09-13 10:42 ` Artem B. Bityuckiy
@ 2005-09-13 10:46 ` Jörn Engel
2005-09-13 11:59 ` Ferenc Havasi
2 siblings, 0 replies; 4+ messages in thread
From: Jörn Engel @ 2005-09-13 10:46 UTC (permalink / raw)
To: zhao forrest; +Cc: linux-mtd
On Tue, 13 September 2005 18:39:33 +0800, zhao forrest wrote:
>
> When writing the eraseblock_header patch, I found the current
> summary patch in MTD CVS place jffs2_sum_marker at the end of
> each erase block. Since jffs2_sum_marker is a per-eraseblock
> structure, should we put it into eraseblock_header when the
> eraseblock_header patch is ready in the future?
Only if we can integrate the crystal ball into JFFS2. Without knowing
what data will be written into the erase block, it's pretty hard to
write the summary ahead of time. ;)
Jörn
--
Schrödinger's cat is <BLINK>not</BLINK> dead.
-- Illiad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Should we put jffs2_sum_marker into eraseblock_header?
2005-09-13 10:39 Should we put jffs2_sum_marker into eraseblock_header? zhao forrest
2005-09-13 10:42 ` Artem B. Bityuckiy
2005-09-13 10:46 ` Jörn Engel
@ 2005-09-13 11:59 ` Ferenc Havasi
2 siblings, 0 replies; 4+ messages in thread
From: Ferenc Havasi @ 2005-09-13 11:59 UTC (permalink / raw)
To: zhao forrest; +Cc: linux-mtd
zhao forrest wrote:
> When writing the eraseblock_header patch, I found the current
> summary patch in MTD CVS place jffs2_sum_marker at the end of
> each erase block. Since jffs2_sum_marker is a per-eraseblock
> structure, should we put it into eraseblock_header when the
> eraseblock_header patch is ready in the future?
The information which is stored in the sum_marker is avaiable only at
the time when the the erase block is under closing. (it is the time when
we store the summary infromation and we know its size)
If the eraseblock_header can be changed at that time than OK, otherwise
it is not helpfull for summary purposes.
Ferenc
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-09-13 12:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-13 10:39 Should we put jffs2_sum_marker into eraseblock_header? zhao forrest
2005-09-13 10:42 ` Artem B. Bityuckiy
2005-09-13 10:46 ` Jörn Engel
2005-09-13 11:59 ` Ferenc Havasi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox