From: "Artem B. Bityuckiy" <dedekind@yandex.ru>
To: Peter Menzebach <pm-mtd@mw-itcon.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: data loss on jffs2 filesystem on dataflash
Date: Thu, 15 Sep 2005 12:47:35 +0400 [thread overview]
Message-ID: <43293527.9010504@yandex.ru> (raw)
In-Reply-To: <43292E94.4020702@mw-itcon.de>
Peter Menzebach wrote:
> - if (!jffs2_can_mark_obsolete(c) && c->nextblock && (c->nextblock->free_size & (c->wbuf_pagesize-1))) {
> + if (!jffs2_can_mark_obsolete(c) && c->nextblock && (c->nextblock->free_size % c->wbuf_pagesize)) {
[snip]
> - uint32_t skip = c->nextblock->free_size & (c->wbuf_pagesize-1);
> + uint32_t skip = c->nextblock->free_size % c->wbuf_pagesize;
[snip]
> -#ifdef CONFIG_JFFS2_FS_WRITEBUFFER
> #define PAGE_DIV(x) ( ((unsigned long)(x) / (unsigned long)(c->wbuf_pagesize)) * (unsigned long)(c->wbuf_pagesize) )
> #define PAGE_MOD(x) ( (unsigned long)(x) % (unsigned long)(c->wbuf_pagesize) )
> -#else
> -#define PAGE_DIV(x) ( (x) & (~(c->wbuf_pagesize - 1)) )
> -#define PAGE_MOD(x) ( (x) & (c->wbuf_pagesize - 1) )
> -#endif
Looks sane.
--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.
next prev parent reply other threads:[~2005-09-15 8:48 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 12:09 data loss on jffs2 filesystem on dataflash Peter Menzebach
2005-09-14 12:30 ` Artem B. Bityuckiy
2005-09-14 13:43 ` Peter Menzebach
2005-09-15 7:48 ` Artem B. Bityuckiy
2005-09-15 7:39 ` Peter Menzebach
2005-09-15 7:49 ` Artem B. Bityuckiy
2005-09-15 7:53 ` Artem B. Bityuckiy
[not found] ` <43292AC6.40809@mw-itcon.de>
[not found] ` <43292E16.70401@yandex.ru>
[not found] ` <43292F91.9010302@mw-itcon.de>
2005-09-20 10:18 ` Artem B. Bityutskiy
[not found] ` <432FEF55.5090700@mw-itcon.de>
2005-09-20 11:21 ` Artem B. Bityutskiy
2005-09-20 13:16 ` Artem B. Bityutskiy
[not found] ` <433006D8.4010502@yandex.ru>
2005-09-20 13:18 ` Artem B. Bityutskiy
2005-09-20 13:38 ` Peter Menzebach
2005-09-20 14:18 ` Artem B. Bityutskiy
2005-09-20 15:01 ` Peter Menzebach
2005-09-20 15:11 ` Andrew Victor
2005-09-20 15:22 ` Jörn Engel
2005-09-20 16:31 ` Artem B. Bityutskiy
2005-09-21 7:21 ` Andrew Victor
2005-09-21 9:25 ` Artem B. Bityutskiy
2005-09-21 10:27 ` Peter Menzebach
2005-09-21 13:36 ` Artem B. Bityutskiy
2005-09-21 13:41 ` Artem B. Bityutskiy
2005-09-21 15:44 ` Peter Menzebach
2005-09-21 15:59 ` Artem B. Bityutskiy
2005-09-21 16:10 ` Peter Menzebach
2005-09-21 16:19 ` Artem B. Bityutskiy
2005-09-21 17:10 ` Peter Menzebach
2005-09-22 10:38 ` Peter Menzebach
2005-09-22 10:51 ` Artem B. Bityutskiy
2005-09-20 15:11 ` Artem B. Bityutskiy
2005-09-20 15:45 ` Peter Menzebach
[not found] ` <20050920133244.GC4634@wohnheim.fh-wedel.de>
[not found] ` <43301877.3040306@yandex.ru>
2005-09-20 14:36 ` Jörn Engel
2005-09-20 14:48 ` Artem B. Bityutskiy
2005-09-15 8:02 ` Artem B. Bityuckiy
[not found] ` <43292E94.4020702@mw-itcon.de>
2005-09-15 8:26 ` Artem B. Bityuckiy
2005-09-15 8:33 ` Peter Menzebach
2005-09-15 8:47 ` Artem B. Bityuckiy [this message]
2005-09-15 9:14 ` Peter Menzebach
2005-09-15 9:25 ` Artem B. Bityuckiy
2005-09-21 13:55 ` Peter Menzebach
2005-09-21 13:59 ` Artem B. Bityutskiy
2005-09-15 10:32 ` Artem B. Bityuckiy
2005-09-22 12:30 ` Peter Menzebach
2005-09-22 12:44 ` Artem B. Bityutskiy
2005-09-22 13:31 ` Peter Menzebach
2005-09-22 14:06 ` Artem B. Bityutskiy
2005-09-22 14:32 ` Andrew Victor
2005-09-22 14:45 ` Artem B. Bityutskiy
2005-09-22 14:59 ` Peter Menzebach
2005-09-22 16:14 ` Peter Menzebach
2005-09-22 17:09 ` Peter Menzebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43293527.9010504@yandex.ru \
--to=dedekind@yandex.ru \
--cc=linux-mtd@lists.infradead.org \
--cc=pm-mtd@mw-itcon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox