From: "Artem B. Bityutskiy" <dedekind@yandex.ru>
To: zhao forrest <zhao_fusheng@hotmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Adding eraseblock header support(revised version)
Date: Thu, 22 Sep 2005 18:37:59 +0400 [thread overview]
Message-ID: <4332C1C7.5090706@yandex.ru> (raw)
In-Reply-To: <BAY17-F11A5B6E921FA39088B715BE8970@phx.gbl>
zhao forrest wrote:
> Your comments for the revised patch are welcome :)
+ if ((!jeb->has_eraseblock_header && jeb->free_size !=
c->sector_size - c->cleanmarker_size) ||
+ (jeb->has_eraseblock_header &&
c->eraseblock_header_size && jeb->free_size != c->sector_size -
jeb->first_node->__totlen) ||
+ (jeb->has_eraseblock_header &&
!c->eraseblock_header_size && jeb->free_size != c->sector_size))
+ {
1. I would not use so looong lines. There is a 80 chars restriction. In
JFFS2 it is OK to use long lines for prints.
2. jeb->has_eraseblock_header - so looong name ... Why not to use
jeb->has_ebh ?
--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.
prev parent reply other threads:[~2005-09-22 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 8:17 [PATCH] Adding eraseblock header support(revised version) zhao forrest
2005-09-22 11:47 ` Artem B. Bityutskiy
2005-09-23 2:45 ` zhao forrest
2005-09-23 8:57 ` Jörn Engel
2005-09-22 12:08 ` Artem B. Bityutskiy
2005-09-23 3:08 ` zhao forrest
2005-09-23 9:23 ` Artem B. Bityutskiy
2005-09-22 14:37 ` Artem B. Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4332C1C7.5090706@yandex.ru \
--to=dedekind@yandex.ru \
--cc=linux-mtd@lists.infradead.org \
--cc=zhao_fusheng@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox