Re: [PATCH] MTD NAND: Fix ECC errors in au1550nd.c

[Vitaly Bordug <vbordug@ru.mvista.com>]

Vitaly Wool wrote:
> Vitaly Bordug wrote:
> 
> <snip>
> 
>> +
>> +            if( (command == NAND_CMD_READ0) || (command == 
>> NAND_CMD_READOOB) ){
>> +                save_flags(g_cpu_flags_cmd);
>> +                cli();
>>  
>>
> Don't you want to sti() it somewhere?
> 


Yes, I understand that saving flags  / clearing interrupts in one mtd 
chip callback and conditionally restoring in another callback seems 
dangerous. I already asked the developer of this code to clarify this 
point (this is excusable in case of the h/w demands of this chip 
unfortunately require something ugly).


-- 
Sincerely,
Vitaly