From: Kaigai Kohei <kaigai@ak.jp.nec.com>
To: "Artem B. Bityutskiy" <dedekind@yandex.ru>
Cc: James Morris <jmorris@redhat.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, lorenzohgh@gmail.com,
Andreas Gruenbacher <agruen@suse.de>
Subject: Re: [PATCH] XATTR issues on JFFS2
Date: Mon, 28 Nov 2005 13:13:38 +0900 [thread overview]
Message-ID: <438A83F2.2080605@ak.jp.nec.com> (raw)
In-Reply-To: <4389D4B2.2050001@yandex.ru>
Hello Artem,
> to ease JFFS2 debugging I split debugging messages by subsystems and one
> may enable/disable debugging messages from each subsystem separately. I
> wonder, if it is possible to add DBG_XATTR() or the like instead of
> using D1()? It really makes bugs hunting easier. Please, glance at debug.h.
I agree what you say.
There is especially no reason why such a stub macro is not used.
In the next patch, I'll use some stub macros as are defined in debug.h.
The following definition will be added in debug.h, and I'll use JFFS2_NOTICE()
and so on instead of raw-printk().
/* Watch the XATTR subsystem */
#ifdef JFFS2_DBG_XATTR_MESSAGES
#define dbg_xattr(fmt, ...) JFFS2_DEBUG(fmt, ##__VA_ARGS__)
#else
#define dbg_xattr(fmt, ...)
#endif
Thanks,
--
Linux Promotion Center, NEC
KaiGai Kohei <kaigai@ak.jp.nec.com>
next prev parent reply other threads:[~2005-11-28 4:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 10:24 [PATCH] XATTR issues on JFFS2 Kaigai Kohei
2005-08-23 12:46 ` Jörn Engel
2005-08-23 12:52 ` David Woodhouse
2005-08-24 9:49 ` Kaigai Kohei
2005-08-25 10:28 ` Kaigai Kohei
2005-08-25 14:12 ` Jörn Engel
2005-09-07 5:14 ` Kaigai Kohei
2005-09-08 19:49 ` Jörn Engel
2005-09-08 19:54 ` David Woodhouse
2005-09-09 4:15 ` Kaigai Kohei
2005-09-09 7:24 ` Jörn Engel
2005-09-10 4:15 ` KaiGai Kohei
2005-09-11 11:46 ` Jörn Engel
2005-09-12 2:17 ` Kaigai Kohei
2005-09-12 6:40 ` Jörn Engel
2005-09-12 11:01 ` Kaigai Kohei
2005-09-28 8:44 ` Kaigai Kohei
2005-09-29 7:45 ` Jörn Engel
2005-10-03 1:01 ` E-mail with attached file has not delivered yet. (Re: [PATCH] XATTR issues on JFFS2) Kaigai Kohei
2005-10-19 13:18 ` [PATCH] XATTR issues on JFFS2 Kaigai Kohei
2005-10-19 14:24 ` Jörn Engel
2005-10-20 2:01 ` Kaigai Kohei
2005-11-27 6:58 ` KaiGai Kohei
2005-11-27 9:43 ` KaiGai Kohei
2005-11-27 15:45 ` Artem B. Bityutskiy
2005-11-28 4:13 ` Kaigai Kohei [this message]
2005-12-03 4:38 ` KaiGai Kohei
2005-10-12 4:25 ` Kaigai Kohei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438A83F2.2080605@ak.jp.nec.com \
--to=kaigai@ak.jp.nec.com \
--cc=agruen@suse.de \
--cc=dedekind@yandex.ru \
--cc=dwmw2@infradead.org \
--cc=jmorris@redhat.com \
--cc=linux-mtd@lists.infradead.org \
--cc=lorenzohgh@gmail.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox