From: Vitaly Wool <vwool@ru.mvista.com>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] MTD: Add support for the MPC8xxADS boards
Date: Tue, 29 Nov 2005 08:39:20 +0300 [thread overview]
Message-ID: <438BE988.5090606@ru.mvista.com> (raw)
In-Reply-To: <438B52FE.9040802@ru.mvista.com>
Hi Vitaly (no, I'm not talking to myself! :) ),
Vitaly Bordug wrote:
>+/* pointer to MPC885ADS board info data */
>+extern unsigned char __res[];
>+
>+static int __init init_mpc8xxads_mtd(void)
>+{
>+ bd_t *bd = (bd_t *)__res;
>
>
I'd like to suggest using platform_data here instead of this global.
Please see how mainstone-flash.c is organized as an example.
Best regards,
Vitaly
prev parent reply other threads:[~2005-11-29 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-28 18:57 [PATCH] MTD: Add support for the MPC8xxADS boards Vitaly Bordug
2005-11-28 20:33 ` Thomas Gleixner
2005-11-29 5:39 ` Vitaly Wool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438BE988.5090606@ru.mvista.com \
--to=vwool@ru.mvista.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox