From: Todd Poynor <tpoynor@mvista.com>
To: "Juha Yrjölä" <juha.yrjola@nokia.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [JFFS2] Make NAND OOB usage more flexible
Date: Thu, 05 Jan 2006 12:07:42 -0800 [thread overview]
Message-ID: <43BD7C8E.3070708@mvista.com> (raw)
In-Reply-To: <1136235272.8963.21.camel@two.research.nokia.com>
Juha Yrjölä wrote:
> + for (i = 0; i < oob_nr; i++) {
> + int j;
> +
> + for (j = 0; j < oob_size; j++) {
> + if (data_len && is_within_clean_marker_area(c, j)) {
> data_len--;
> continue;
> }
> - if (buf[i*oob_size+j] != 0xFF) {
> + if (buf[i * oob_size + j] != 0xff) {
> ret = 1;
Just found a reason to use AUTOPLACE info to avoid unavailable bytes
when checking for 0xFF in the non-cleanmarker/EBH bytes as well: there's
at least one NAND H/W controller that generates non-0xFF ECC bytes for
writes of all 0xFF (not sure if that's a bug), and its handy to have
such writes continue to look like an empty page. Anyhow, holding out
hope for Vitaly's solution, but can send a patch if this is messing
anybody up in the meantime.
--
Todd
prev parent reply other threads:[~2006-01-05 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-02 20:54 [PATCH] [JFFS2] Make NAND OOB usage more flexible Juha Yrjölä
2006-01-05 12:31 ` Vitaly Wool
2006-01-05 12:54 ` Artem B. Bityutskiy
2006-01-05 13:20 ` Juha Yrjölä
2006-01-05 13:29 ` Vitaly Wool
2006-01-06 2:20 ` zhao, forrest
2006-01-05 12:49 ` Artem B. Bityutskiy
2006-01-05 20:07 ` Todd Poynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BD7C8E.3070708@mvista.com \
--to=tpoynor@mvista.com \
--cc=juha.yrjola@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox